feat: dynamic controller switching#88
Conversation
|
not the linting 💀 |
samfreund
changed the title
samfreund
changed the title
|
I gotta admit, this feels a little excessive. I think all that we really need is changing the controller checking to default to an xbox controller in sim. In a case where we need to use test mode, I expect that we'll likely be changing code as well, so it's not a big deal to need to redeploy. |
samfreund
left a comment
samfreund
left a comment
There was a problem hiding this comment.
This is looking pretty good. I'd like to see some testing where we determine that there aren't going to be any edge cases, and I want to see that if we have a random disconnect it'll automatically pick the controllers back up. Also, merge main into this. After I see that testing, this should be good to go.
| if (Constants.IOConstants.kTestMode) { | ||
| System.out.println("Test Mode Enabled\nNot for competition use"); | ||
| } | ||
| this.m_robotContainer.updateControllerConnections(); |
There was a problem hiding this comment.
idk how I feel about this calling every single control loop. That feels maybe excessive.
There was a problem hiding this comment.
If you can demonstrate it doesn't make an impact tho I'm fine with it.
| if (Constants.IOConstants.kTestMode) { | ||
| System.out.println("Test Mode Enabled\nNot for competition use"); | ||
| } | ||
| this.m_robotContainer.updateControllerConnections(); |
There was a problem hiding this comment.
If you can demonstrate it doesn't make an impact tho I'm fine with it.
4 participants
No description provided.