Add support for counting custom elements and unknown elements #37
Conversation
arronei
commented
Mar 3, 2017
arronei
commented
- Added checks and counts for Unknown element
- Added checks and counts for Custom element
- Added test case into current test file
There was a problem hiding this comment.
I'm not going to merge this in until I can satisfy that @mustjab has kicked off our current run and this one won't be fetched until I can ensure that it runs without any errors.
|
|
||
| // If the browser doesn't recognize the element - throw it away | ||
| if(element instanceof HTMLUnknownElement) { | ||
| node = "**UNKNOWN"; |
There was a problem hiding this comment.
Why are you doing this custom naming of **UNKNOWN and **CUSTOM? This is going to mean nothing to everyone else IMO.
There was a problem hiding this comment.
HTMLCustomElement didn't make sense since there isn't such a thing. And HTMLUnknownElement wasn't correct since there is no element named that.
I figured creating 2 special names that bubble up to the top would be the best solution. Though I am not really tied to it.
There was a problem hiding this comment.
Ok, then we'll keep this we can always change it later.
|
@arronei Before doing this can you add in the namespacing of the elements as well. I'm thinking the best way to do this is by adding it in an additional column with the namespace. |
