-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update entra-id-tutorial.md #10055
Update entra-id-tutorial.md #10055
Conversation
Added options for using proxy server with Entra ID as it was found that the Arc Agent proxy does not use this for Entra ID authentication, and the machine wide proxy needs to be used.
@wjpigott : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
@wjpigott : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
Learn Build status updates of commit 722e14b: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
Made some changes including the explicit access if the proxy is not used.
Added some other comments on a second commit. let me know if I need to do anything else here. |
Learn Build status updates of commit add73d0:
|
File | Status | Preview URL | Details |
---|---|---|---|
docs/includes/entra-id-tutorial.md | Details |
docs/includes/entra-id-tutorial.md
- Line 49, Column 75: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/sql/sql-server/azure-arc/prerequisites?view=sql-server-ver16&tabs=azure#network-requirements-for-enabling-entra-id-authentication' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
- Line 49, Column 75: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/sql/sql-server/azure-arc/prerequisites?view=sql-server-ver16&tabs=azure#network-requirements-for-enabling-entra-id-authentication' will be broken in isolated environments. Replace with a relative link.
- Line 49, Column 75: [Suggestion: preserve-view-not-set - See documentation]
You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL. Otherwise, remove the view parameter. URL: https://learn.microsoft.com/en-us/sql/sql-server/azure-arc/prerequisites?view=sql-server-ver16&tabs=azure#network-requirements-for-enabling-entra-id-authentication
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
@wjpigott I am closing this PR. Microsoft employees and vendors should use the Thanks! |
Please help here as I edit docs all the time and followed normal process I was aware of. If there is another repo please feel free to hit me up on teams.
Thank you,
Jeff Pigott
…________________________________
From: Randolph West MSFT ***@***.***>
Sent: Friday, April 4, 2025 2:00:25 PM
To: MicrosoftDocs/sql-docs ***@***.***>
Cc: Jeff Pigott ***@***.***>; Mention ***@***.***>
Subject: Re: [MicrosoftDocs/sql-docs] Update entra-id-tutorial.md (PR #10055)
@wjpigott<https://github.com/wjpigott> I am closing this PR. Microsoft employees and vendors should use the sql-docs-pr repository. If you need help moving this to that repo, please let me know.
Thanks!
—
Reply to this email directly, view it on GitHub<#10055 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AUTYXEL7K62LLSCELKVH2ST2X3JETAVCNFSM6AAAAAB2H6YUB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONZZGUZDSMRYGA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
[rwestMSFT]rwestMSFT left a comment (MicrosoftDocs/sql-docs#10055)<#10055 (comment)>
@wjpigott<https://github.com/wjpigott> I am closing this PR. Microsoft employees and vendors should use the sql-docs-pr repository. If you need help moving this to that repo, please let me know.
Thanks!
—
Reply to this email directly, view it on GitHub<#10055 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AUTYXEL7K62LLSCELKVH2ST2X3JETAVCNFSM6AAAAAB2H6YUB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONZZGUZDSMRYGA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@wjpigott Please refer to https://github.com/MicrosoftDocs/sql-docs-pr/pull/33717. All you need to do in future, is target |
Thank you!!
From: Randolph West MSFT ***@***.***>
Sent: Friday, April 4, 2025 3:05 PM
To: MicrosoftDocs/sql-docs ***@***.***>
Cc: Jeff Pigott ***@***.***>; Mention ***@***.***>
Subject: Re: [MicrosoftDocs/sql-docs] Update entra-id-tutorial.md (PR #10055)
@wjpigott<https://github.com/wjpigott> Please refer to MicrosoftDocs/sql-docs-pr#33717<MicrosoftDocs/sql-docs-pr#33717>. All you need to do in future, is target sql-docs-pr instead of sql-docs.
-
Reply to this email directly, view it on GitHub<#10055 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AUTYXEPFSOWE5BPPU23AHXL2X3QWVAVCNFSM6AAAAAB2H6YUB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONZZGYZTKMJQGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
[rwestMSFT]rwestMSFT left a comment (MicrosoftDocs/sql-docs#10055)<#10055 (comment)>
@wjpigott<https://github.com/wjpigott> Please refer to MicrosoftDocs/sql-docs-pr#33717<MicrosoftDocs/sql-docs-pr#33717>. All you need to do in future, is target sql-docs-pr instead of sql-docs.
-
Reply to this email directly, view it on GitHub<#10055 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AUTYXEPFSOWE5BPPU23AHXL2X3QWVAVCNFSM6AAAAAB2H6YUB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONZZGYZTKMJQGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
Added options for using proxy server with Entra ID as it was found that the Arc Agent proxy does not use this for Entra ID authentication, and the machine wide proxy needs to be used.