Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update entra-id-tutorial.md #10055

Closed
wants to merge 2 commits into from
Closed

Conversation

wjpigott
Copy link

@wjpigott wjpigott commented Apr 1, 2025

Added options for using proxy server with Entra ID as it was found that the Arc Agent proxy does not use this for Entra ID authentication, and the machine wide proxy needs to be used.

Added options for using proxy server with Entra ID as it was found that the Arc Agent proxy does not use this for Entra ID authentication, and the machine wide proxy needs to be used.
Copy link
Contributor

@wjpigott : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

Copy link
Contributor

@wjpigott : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 722e14b:

✅ Validation status: passed

File Status Preview URL Details
docs/includes/entra-id-tutorial.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@v-dirichards
Copy link
Contributor

@MikeRayMSFT

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Apr 1, 2025
Made some changes including the explicit access if the proxy is not used.
@wjpigott
Copy link
Author

wjpigott commented Apr 2, 2025

Added some other comments on a second commit. let me know if I need to do anything else here.

Copy link
Contributor

Learn Build status updates of commit add73d0:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/includes/entra-id-tutorial.md ⚠️Warning Details

docs/includes/entra-id-tutorial.md

  • Line 49, Column 75: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/sql/sql-server/azure-arc/prerequisites?view=sql-server-ver16&tabs=azure#network-requirements-for-enabling-entra-id-authentication' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 49, Column 75: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/sql/sql-server/azure-arc/prerequisites?view=sql-server-ver16&tabs=azure#network-requirements-for-enabling-entra-id-authentication' will be broken in isolated environments. Replace with a relative link.
  • Line 49, Column 75: [Suggestion: preserve-view-not-set - See documentation] You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL. Otherwise, remove the view parameter. URL: https://learn.microsoft.com/en-us/sql/sql-server/azure-arc/prerequisites?view=sql-server-ver16&tabs=azure#network-requirements-for-enabling-entra-id-authentication

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@rwestMSFT
Copy link
Contributor

@wjpigott I am closing this PR. Microsoft employees and vendors should use the sql-docs-pr repository. If you need help moving this to that repo, please let me know.

Thanks!

@rwestMSFT rwestMSFT closed this Apr 4, 2025
@wjpigott
Copy link
Author

wjpigott commented Apr 4, 2025 via email

@rwestMSFT
Copy link
Contributor

@wjpigott Please refer to https://github.com/MicrosoftDocs/sql-docs-pr/pull/33717. All you need to do in future, is target sql-docs-pr instead of sql-docs.

@wjpigott
Copy link
Author

wjpigott commented Apr 4, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants