Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PowerShell Boolean casting issue in Execute method #10044

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

kaczynskim
Copy link
Contributor

@kaczynskim kaczynskim commented Mar 20, 2025

This PR corrects a misleading example in the PowerShell example for the PackageInfo.Execute method usage.

Issue:
In PowerShell, passing "false" (a string) instead of $false (a Boolean) incorrectly evaluates to $true.

Fix:
Updated documentation to clarify that false should be passed as $false (Boolean) instead of "false" (string).
Ensured that examples use the correct Boolean syntax to prevent execution mode misconfigurations.

Impact:
This fix ensures that users do not unintentionally enable 32-bit execution mode due to incorrect PowerShell type casting.

Reference Issue:
PowerShell automatically evaluates non-empty strings as $true, causing Execute("false", $envRef) to behave incorrectly.
Expected usage should be Execute($false, $envRef).

Please review and approve.

Powershell cast "false" to $True. Instead of "false", $false should be used
Copy link
Contributor

@kaczynskim : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit e9d83dd:

✅ Validation status: passed

File Status Preview URL Details
docs/integration-services/ssis-quickstart-run-powershell.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@v-dirichards
Copy link
Contributor

@chugugrace Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Mar 20, 2025
@rwestMSFT
Copy link
Contributor

Thanks for your contribution. I'm merging this PR as it looks correct.

@rwestMSFT rwestMSFT merged commit 613bdf2 into MicrosoftDocs:live Apr 4, 2025
2 checks passed
Copy link
Contributor

PR 10044 has been merged from kaczynskim:patch-1 to MicrosoftDocs:live by rwestMSFT.

@kaczynskim, @chugugrace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants