Skip to content

Conversation

hashwnath
Copy link

…ta Agent Python Client

The MS Learn article for “Consume Fabric data agent from external applications with Python client SDK” uses DataAgentClient, while the official GitHub repo uses FabricDataAgentClient. The constructor signatures differ: Learn shows credential=InteractiveBrowserCredential(), whereas the repo expects tenant_id and data_agent_url. Additionally, Learn references a fabric-data-agent-client package, but the repo only documents cloning and installing via requirements.txt. Please align the import name, initialization method, and installation steps between the documentation and the repo, or clarify if a new package is planned.
Ref - MS Learn Doc: https://learn.microsoft.com/en-us/fabric/data-science/consume-data-agent-python?tabs=windows%2Cvariables

Ref - microsoft/fabric_data_agent_client#6

Thank you for contributing to Microsoft Fabric documentation

Fill out these items before submitting your pull request:

If you are working internally at Microsoft:
Provide a link to an Azure DevOps Boards work item that tracks this feature/update.

Who is your primary Skilling team contact? @mention them individually tag them and let them review the PR before signing off.

For internal Microsoft contributors, check off these quality control items as you go

  • 1. Check the Acrolinx report: Make sure your Acrolinx Total score is above 80 minimum (higher is better) and with no spelling issues. Acrolinx ensures we are providing consistent terminology and using an appropriate voice and tone, and helps with localization.

  • 2. Successful build with no warnings or suggestions: Review the build status to make sure all files are green (Succeeded).

  • 3. Preview the pages:: Click each Preview URL link to view the rendered HTML pages on the review.learn.microsoft.com site to check the formatting and alignment of the page. Scan the page for overall formatting, and look at the parts you edited in detail.

  • 4. Check the Table of Contents: If you are adding a new markdown file, make sure it is linked from the table of contents.

  • 5. #sign-off to request PR review and merge: Once the pull request is finalized and ready to be merged, indicate so by typing #sign-off in a new comment in the Pull Request. If you need to cancel that sign-off, type #hold-off instead. Signing off means the document can be published at any time. Note, this is a formatting and standards review, not a technical review.

Merge and publish

  • After you #sign-off, there is a separate PR Review team that will review the PR and describe any necessary feedback before merging.
  • The review team will use the comments section in the PR to provide feedback if changes are needed. Address any blocking issues and sign off again to request another review.
  • Once all feedback is resolved, you can #sign-off again. The PR Review team reviews and merges the pull request into the specified branch (usually the main branch or a release- branch).
  • From the main branch, the change is merged into the live branch several times a day to publish it to the public learn.microsoft.com site.

…ta Agent Python Client

The MS Learn article for “Consume Fabric data agent from external applications with Python client SDK” uses DataAgentClient, while the official GitHub repo uses FabricDataAgentClient. The constructor signatures differ: Learn shows credential=InteractiveBrowserCredential(), whereas the repo expects tenant_id and data_agent_url. Additionally, Learn references a fabric-data-agent-client package, but the repo only documents cloning and installing via requirements.txt. Please align the import name, initialization method, and installation steps between the documentation and the repo, or clarify if a new package is planned.
Ref - MS Learn Doc: https://learn.microsoft.com/en-us/fabric/data-science/consume-data-agent-python?tabs=windows%2Cvariables

Ref - microsoft/fabric_data_agent_client#6
Copy link
Contributor

@hashwnath : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit a24f1fd:

✅ Validation status: passed

File Status Preview URL Details
docs/data-science/consume-data-agent-python.md ✅Succeeded

For more details, please refer to the build report.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Fabric data agent Python client documentation to fix inconsistencies with the official GitHub repository implementation. The documentation was referencing an incorrect class name and constructor signature.

  • Updates import statement to use the correct FabricDataAgentClient class name
  • Aligns client instantiation to match the repository's interface

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@v-dirichards
Copy link
Contributor

@jonburchel

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants