Fix multi-container and multi-host overwrites#424
Open
libots wants to merge 27 commits intoMichelFR:mainfrom
Open
Fix multi-container and multi-host overwrites#424libots wants to merge 27 commits intoMichelFR:mainfrom
libots wants to merge 27 commits intoMichelFR:mainfrom
Conversation
Bumps [@types/lodash](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/lodash) from 4.17.13 to 4.17.14. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/lodash) --- updated-dependencies: - dependency-name: "@types/lodash" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [dockerode](https://github.com/apocas/dockerode) from 4.0.2 to 4.0.3. - [Release notes](https://github.com/apocas/dockerode/releases) - [Commits](apocas/dockerode@v4.0.2...v4.0.3) --- updated-dependencies: - dependency-name: dockerode dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [yaml](https://github.com/eemeli/yaml) from 2.6.1 to 2.7.0. - [Release notes](https://github.com/eemeli/yaml/releases) - [Commits](eemeli/yaml@v2.6.1...v2.7.0) --- updated-dependencies: - dependency-name: yaml dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@types/dockerode](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/dockerode) from 3.3.32 to 3.3.34. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/dockerode) --- updated-dependencies: - dependency-name: "@types/dockerode" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [typescript](https://github.com/microsoft/TypeScript) from 5.7.2 to 5.7.3. - [Release notes](https://github.com/microsoft/TypeScript/releases) - [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release.yml) - [Commits](microsoft/TypeScript@v5.7.2...v5.7.3) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [dockerode](https://github.com/apocas/dockerode) from 4.0.3 to 4.0.4. - [Release notes](https://github.com/apocas/dockerode/releases) - [Commits](apocas/dockerode@v4.0.3...v4.0.4) --- updated-dependencies: - dependency-name: dockerode dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@types/lodash](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/lodash) from 4.17.14 to 4.17.15. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/lodash) --- updated-dependencies: - dependency-name: "@types/lodash" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [npm](https://github.com/npm/cli) from 11.0.0 to 11.1.0. - [Release notes](https://github.com/npm/cli/releases) - [Changelog](https://github.com/npm/cli/blob/latest/CHANGELOG.md) - [Commits](npm/cli@libnpmhook-v11.0.0...v11.1.0) --- updated-dependencies: - dependency-name: npm dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Fixes MichelFR#404 Add error handling and container restart logic in DockerService.updateContainer function. * Add try-catch block to handle errors during container restart. * Log errors if container restart fails. * Ensure container is restarted with the new image. * Remove old image after container restart. * Publish final 100% progress message after successful container restart. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/MichelFR/MqDockerUp/issues/404?shareId=XXXX-XXXX-XXXX-XXXX).
Contributor
|
Looks great, I hope this get merged |
Contributor
|
Any indication if this will be merged? Multi-host would really improve the functionality of the program. |
Owner
I'm gonna do some tests on this soon. |
|
Any news on this topic? I kind of hit the same wall… |
|
Would this Pull Request also solve the issue with entity names in Home Assistant discovery? For example: I assume you're using the image to build some entities and the container name to build others. |
|
Is there some updates on this? It could fix a lot of problems, maybe also this #572 ! |
Contributor
|
Any hope for this being merged? It would greatly increase the utility. |
|
any hope for this getting merged some day? |
MichelFR
force-pushed
the
main
branch
2 times, most recently
from
1b35914 to
3e8f3a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relabels MQTT topics to work in prefix and container name to enable multiple copies of containers with same image and multiple hosts with containers with same image to not overwrite each other. #261 and #264.