Skip to content

added dark color scheme#42

Open
Mi-Lan wants to merge 3 commits intomasterfrom
feature/dark-color
Open

added dark color scheme#42
Mi-Lan wants to merge 3 commits intomasterfrom
feature/dark-color

Conversation

@Mi-Lan
Copy link
Owner

@Mi-Lan Mi-Lan commented Mar 4, 2021

I changed color theme to be dark by default
closes #29

@Mi-Lan Mi-Lan added the enhancement New feature or request label Mar 4, 2021
@Mi-Lan Mi-Lan self-assigned this Mar 7, 2021
@KeenanLukeOM
Copy link
Collaborator

Personally, I like the look of dark mode - but light mode should be the default when a new user arrives. This is generally more welcoming, which is the goal of the book.

I think we should implement a button that switches between the two styles. (I believe mentioned in #29, replacing the "This site uses Just the Docs, a documentation theme for Jekyll." text in the bottom). Bonus points if the preferred setting persists between different visits.

@Mi-Lan
Copy link
Owner Author

Mi-Lan commented Mar 9, 2021

Personally, I like the look of dark mode - but light mode should be the default when a new user arrives. This is generally more welcoming, which is the goal of the book.

I think we should implement a button that switches between the two styles. (I believe mentioned in #29, replacing the "This site uses Just the Docs, a documentation theme for Jekyll." text in the bottom). Bonus points if the preferred setting persists between different visits.

@KeenanLukeOM Added button for switching and also it saves what theme you selected in LocalStorage so it will persist between closing on browser and tabs...

@KeenanLukeOM
Copy link
Collaborator

This is awesome! @Mi-Lan

I have been trying for quite a while to make sure it isn't on my end, but something since the last build has caused big blue bars to appear when navigating between any category. It will be white, regardless of being in dark mode or not. Take a look at what I see here:

https://i.gyazo.com/f8b4db19703e58d4d0722e4df4b24301.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable Just the Docs dark color scheme

2 participants