Fix/crossfade player state#2809
Merged
mostafaalagamy merged 2 commits intoMetrolistGroup:mainfrom Feb 14, 2026
Merged
Conversation
This fixes issues where Repeat Mode (One/All) and Shuffle were being reset or ignored, particularly when Crossfade was involved. - Prevent restorePlayerState from overwriting authoritative DataStore settings on startup - Initialize secondary crossfade player using DataStore settings - Add safety checks to enforce Repeat One/All behavior during transitions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes critical bugs where
Repeat ModeandShufflesettings were being ignored or reset, particularly when Crossfade was enabled (or even present in the codebase).Changes
restorePlayerStatefrom overwriting authoritative DataStore settings with stale internal player state during app startup.startCrossfadenow reads settings directly from DataStore to ensure the new secondary player is initialized with the correct Repeat/Shuffle modes.onMediaItemTransitionandonPlaybackStateChangedto strictly enforceREPEAT_MODE_ONE(loop song) andREPEAT_MODE_ALL(loop queue) behavior, correcting the player if it attempts to auto-advance incorrectly.Fixes
Fixes #2751