Fix/playlist sort direction#2786
Merged
mostafaalagamy merged 2 commits intoMetrolistGroup:mainfrom Feb 14, 2026
Merged
Conversation
…t dialog Fixes MetrolistGroup#2779 - the library screen and 'Add to Playlist' popup were sharing the same preference key 'playlistSortDescending'. Changed to unique key 'addToPlaylistSortDescending' so they can be sorted independently.
Contributor
Author
|
That's my favorite pull request because that was the easier one |
|
Thanks a ton! It's those simple fixes that really show the benefits of Open Source :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2779 by separating the playlist sort direction preference between the library screen and the "Add to Playlist" popup.
Problem
The library screen and "Add to Playlist" popup were sharing the same preference key
playlistSortDescending. This meant:Solution
Changed line 154 in
PreferenceKeys.ktto use a unique preference key:booleanPreferencesKey("playlistSortDescending")(shared)booleanPreferencesKey("addToPlaylistSortDescending")(unique)Testing
Checklist