chore: Merge main into 7.20.0 #9230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## **Description** Patches MetaMask/core#3797 to support pricing linea erc20 tokens. ## **Related issues** ## **Manual testing steps** 1. Open wallet containing linea erc20 tokens 2. Should have fiat prices ## **Screenshots/Recordings** ### **Before** <img width="417" alt="Screenshot 2024-04-01 at 12 47 55 PM" src="https://github.com/MetaMask/metamask-mobile/assets/3500406/e6da264b-d21d-4711-9396-34ba31b732eb"> ### **After** <img width="416" alt="Screenshot 2024-04-01 at 12 40 05 PM" src="https://github.com/MetaMask/metamask-mobile/assets/3500406/9533d8e6-97ac-4cd1-8670-fce8461323e5"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
…onnection (#8745) ## **Description** This PR is to fix #8643 and #8718 issue This PR has done following change: 1. for Android 12 and above, we only need `nearby devices` permission for ledger bluetooth connection. not required `location` permission any more. 2. for Android 11, system will only require `location` permission with `precise location` on to work with ledger. 3. Add `nearby devices` permission error message in `en.json` 4. styling the `ErrorDetail` modal to fit the new `nearby devices` in the screen. ## **Related issues** Fixes: #8643 #8718 ## **Manual testing steps** 1. From Android settings>connected devices> see all make sure LNX not currently paired 2. Have LNX unlocked and the Ethereum app opened 3. Unlock MMM 4. Tap accounts menu from wallet view 5. Select `add account or hardware wallet` 6. Tap `Add hardware wallet` 7. Tap `Ledger` 8. When nearby permission is requested, decline it 9. when error page appear, click `view settings` which direct to `setting` page of metamask permission 10. enable `Nearby Devices` permission, and click `back` to app 11. metamask will go back to scan screen and then find LNX devices. 12. click continue, LNX account will be imported. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <div style="display: inline-block"> <img width="183" src="https://github.com/MetaMask/metamask-mobile/assets/32695229/6c637e42-4c40-4e63-8e8a-f3f7e48a2374"><img width="190" src="https://github.com/MetaMask/metamask-mobile/assets/32695229/1563ebeb-d88a-4b6e-ba01-e2a59812d1c0"></div> ### **After** https://github.com/MetaMask/metamask-mobile/assets/7315988/d2ba2433-2781-48e0-9c3d-a32d5f16435c <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [x] I've included manual testing steps - [x] I've included screenshots/recordings if applicable - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I’ve properly set the pull request status: - [x] In case it's not yet "ready for review", I've set it to "draft". - [x] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Sébastien Van Eyck <[email protected]> Co-authored-by: Omridan159 <[email protected]> Co-authored-by: Nico MASSART <[email protected]>
- unit test metametrics at app startup - update snapshot - update test names to match guidelines [Fixes uncovered code](https://app.codecov.io/gh/MetaMask/metamask-mobile/pull/8937/blob/app/components/Nav/App/index.js#L373)
Bumps [webpack-dev-middleware](https://github.com/webpack/webpack-dev-middleware) from 6.1.1 to 6.1.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/webpack/webpack-dev-middleware/releases">webpack-dev-middleware's releases</a>.</em></p> <blockquote> <h2>v6.1.2</h2> <h3><a href="https://github.com/webpack/webpack-dev-middleware/compare/v6.1.1...v6.1.2">6.1.2</a> (2024-03-20)</h3> <h3>Bug Fixes</h3> <ul> <li><strong>security:</strong> do not allow to read files above (<a href="https://redirect.github.com/webpack/webpack-dev-middleware/issues/1778">#1778</a>) (<a href="https://github.com/webpack/webpack-dev-middleware/commit/9670b3495da518fe667ff3428c5e4cb9f2f3d353">9670b34</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/webpack/webpack-dev-middleware/blob/v6.1.2/CHANGELOG.md">webpack-dev-middleware's changelog</a>.</em></p> <blockquote> <h3><a href="https://github.com/webpack/webpack-dev-middleware/compare/v6.1.1...v6.1.2">6.1.2</a> (2024-03-20)</h3> <h3>Bug Fixes</h3> <ul> <li><strong>security:</strong> do not allow to read files above (<a href="https://redirect.github.com/webpack/webpack-dev-middleware/issues/1778">#1778</a>) (<a href="https://github.com/webpack/webpack-dev-middleware/commit/9670b3495da518fe667ff3428c5e4cb9f2f3d353">9670b34</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/webpack/webpack-dev-middleware/commit/54e4a9604905898066979a3a918d3d545f761447"><code>54e4a96</code></a> chore(release): 6.1.2</li> <li><a href="https://github.com/webpack/webpack-dev-middleware/commit/9670b3495da518fe667ff3428c5e4cb9f2f3d353"><code>9670b34</code></a> fix(security): do not allow to read files above (<a href="https://redirect.github.com/webpack/webpack-dev-middleware/issues/1778">#1778</a>)</li> <li>See full diff in <a href="https://github.com/webpack/webpack-dev-middleware/compare/v6.1.1...v6.1.2">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/MetaMask/metamask-mobile/network/alerts). </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: sethkfman <[email protected]>
Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.19.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/expressjs/express/releases">express's releases</a>.</em></p> <blockquote> <h2>4.19.2</h2> <h2>What's Changed</h2> <ul> <li><a href="https://github.com/expressjs/express/commit/0b746953c4bd8e377123527db11f9cd866e39f94">Improved fix for open redirect allow list bypass</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/expressjs/express/compare/4.19.1...4.19.2">https://github.com/expressjs/express/compare/4.19.1...4.19.2</a></p> <h2>4.19.1</h2> <h2>What's Changed</h2> <ul> <li>Fix ci after location patch by <a href="https://github.com/wesleytodd"><code>@wesleytodd</code></a> in <a href="https://redirect.github.com/expressjs/express/pull/5552">expressjs/express#5552</a></li> <li>fixed un-edited version in history.md for 4.19.0 by <a href="https://github.com/wesleytodd"><code>@wesleytodd</code></a> in <a href="https://redirect.github.com/expressjs/express/pull/5556">expressjs/express#5556</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/expressjs/express/compare/4.19.0...4.19.1">https://github.com/expressjs/express/compare/4.19.0...4.19.1</a></p> <h2>4.19.0</h2> <h2>What's Changed</h2> <ul> <li>fix typo in release date by <a href="https://github.com/UlisesGascon"><code>@UlisesGascon</code></a> in <a href="https://redirect.github.com/expressjs/express/pull/5527">expressjs/express#5527</a></li> <li>docs: nominating <a href="https://github.com/wesleytodd"><code>@wesleytodd</code></a> to be project captian by <a href="https://github.com/wesleytodd"><code>@wesleytodd</code></a> in <a href="https://redirect.github.com/expressjs/express/pull/5511">expressjs/express#5511</a></li> <li>docs: loosen TC activity rules by <a href="https://github.com/wesleytodd"><code>@wesleytodd</code></a> in <a href="https://redirect.github.com/expressjs/express/pull/5510">expressjs/express#5510</a></li> <li>Add note on how to update docs for new release by <a href="https://github.com/crandmck"><code>@crandmck</code></a> in <a href="https://redirect.github.com/expressjs/express/pull/5541">expressjs/express#5541</a></li> <li><a href="https://redirect.github.com/expressjs/express/pull/5551/commits/660ccf5fa33dd0baab069e5c8ddd9ffe7d8bbff1">Prevent open redirect allow list bypass due to encodeurl</a></li> <li>Release 4.19.0 by <a href="https://github.com/wesleytodd"><code>@wesleytodd</code></a> in <a href="https://redirect.github.com/expressjs/express/pull/5551">expressjs/express#5551</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/crandmck"><code>@crandmck</code></a> made their first contribution in <a href="https://redirect.github.com/expressjs/express/pull/5541">expressjs/express#5541</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/expressjs/express/compare/4.18.3...4.19.0">https://github.com/expressjs/express/compare/4.18.3...4.19.0</a></p> <h2>4.18.3</h2> <h2>Main Changes</h2> <ul> <li>Fix routing requests without method</li> <li>deps: [email protected] <ul> <li>Fix strict json error message on Node.js 19+</li> <li>deps: content-type@~1.0.5</li> <li>deps: [email protected]</li> </ul> </li> </ul> <h2>Other Changes</h2> <ul> <li>Use https: protocol instead of deprecated git: protocol by <a href="https://github.com/vcsjones"><code>@vcsjones</code></a> in <a href="https://redirect.github.com/expressjs/express/pull/5032">expressjs/express#5032</a></li> <li>build: [email protected] and [email protected] by <a href="https://github.com/abenhamdine"><code>@abenhamdine</code></a> in <a href="https://redirect.github.com/expressjs/express/pull/5034">expressjs/express#5034</a></li> <li>ci: update actions/checkout to v3 by <a href="https://github.com/armujahid"><code>@armujahid</code></a> in <a href="https://redirect.github.com/expressjs/express/pull/5027">expressjs/express#5027</a></li> <li>test: remove unused function arguments in params by <a href="https://github.com/raksbisht"><code>@raksbisht</code></a> in <a href="https://redirect.github.com/expressjs/express/pull/5124">expressjs/express#5124</a></li> <li>Remove unused originalIndex from acceptParams by <a href="https://github.com/raksbisht"><code>@raksbisht</code></a> in <a href="https://redirect.github.com/expressjs/express/pull/5119">expressjs/express#5119</a></li> <li>Fixed typos by <a href="https://github.com/raksbisht"><code>@raksbisht</code></a> in <a href="https://redirect.github.com/expressjs/express/pull/5117">expressjs/express#5117</a></li> <li>examples: remove unused params by <a href="https://github.com/raksbisht"><code>@raksbisht</code></a> in <a href="https://redirect.github.com/expressjs/express/pull/5113">expressjs/express#5113</a></li> <li>fix: parameter str is not described in JSDoc by <a href="https://github.com/raksbisht"><code>@raksbisht</code></a> in <a href="https://redirect.github.com/expressjs/express/pull/5130">expressjs/express#5130</a></li> <li>fix: typos in History.md by <a href="https://github.com/raksbisht"><code>@raksbisht</code></a> in <a href="https://redirect.github.com/expressjs/express/pull/5131">expressjs/express#5131</a></li> <li>build : add [email protected] by <a href="https://github.com/abenhamdine"><code>@abenhamdine</code></a> in <a href="https://redirect.github.com/expressjs/express/pull/5028">expressjs/express#5028</a></li> <li>test: remove unused function arguments in params by <a href="https://github.com/raksbisht"><code>@raksbisht</code></a> in <a href="https://redirect.github.com/expressjs/express/pull/5137">expressjs/express#5137</a></li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/expressjs/express/blob/master/History.md">express's changelog</a>.</em></p> <blockquote> <h1>4.19.2 / 2024-03-25</h1> <ul> <li>Improved fix for open redirect allow list bypass</li> </ul> <h1>4.19.1 / 2024-03-20</h1> <ul> <li>Allow passing non-strings to res.location with new encoding handling checks</li> </ul> <h1>4.19.0 / 2024-03-20</h1> <ul> <li>Prevent open redirect allow list bypass due to encodeurl</li> <li>deps: [email protected]</li> </ul> <h1>4.18.3 / 2024-02-29</h1> <ul> <li>Fix routing requests without method</li> <li>deps: [email protected] <ul> <li>Fix strict json error message on Node.js 19+</li> <li>deps: content-type@~1.0.5</li> <li>deps: [email protected]</li> </ul> </li> <li>deps: [email protected] <ul> <li>Add <code>partitioned</code> option</li> </ul> </li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/expressjs/express/commit/04bc62787be974874bc1467b23606c36bc9779ba"><code>04bc627</code></a> 4.19.2</li> <li><a href="https://github.com/expressjs/express/commit/da4d763ff6ba9df6dbd8f1f0b1d05412dda934d5"><code>da4d763</code></a> Improved fix for open redirect allow list bypass</li> <li><a href="https://github.com/expressjs/express/commit/4f0f6cc67d531431c096ea006c2191b92931bbc3"><code>4f0f6cc</code></a> 4.19.1</li> <li><a href="https://github.com/expressjs/express/commit/a003cfab034fbadb1c78ae337ee8ab389adda217"><code>a003cfa</code></a> Allow passing non-strings to res.location with new encoding handling checks f...</li> <li><a href="https://github.com/expressjs/express/commit/a1fa90fcea7d8e844e1c9938ad095d62669c3abd"><code>a1fa90f</code></a> fixed un-edited version in history.md for 4.19.0</li> <li><a href="https://github.com/expressjs/express/commit/11f2b1db227fd42c2508c427032c1ec671b306be"><code>11f2b1d</code></a> build: fix build due to inconsistent supertest behavior in older versions</li> <li><a href="https://github.com/expressjs/express/commit/084e36506a18774f85206a65d8da04dc1107fc1b"><code>084e365</code></a> 4.19.0</li> <li><a href="https://github.com/expressjs/express/commit/0867302ddbde0e9463d0564fea5861feb708c2dd"><code>0867302</code></a> Prevent open redirect allow list bypass due to encodeurl</li> <li><a href="https://github.com/expressjs/express/commit/567c9c665d0de4c344b8e160146050770233783c"><code>567c9c6</code></a> Add note on how to update docs for new release (<a href="https://redirect.github.com/expressjs/express/issues/5541">#5541</a>)</li> <li><a href="https://github.com/expressjs/express/commit/69a4cf2819c4449ec6ea45649691fb43a528d5d1"><code>69a4cf2</code></a> deps: [email protected]</li> <li>Additional commits viewable in <a href="https://github.com/expressjs/express/compare/4.18.2...4.19.2">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~wesleytodd">wesleytodd</a>, a new releaser for express since your current version.</p> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/MetaMask/metamask-mobile/network/alerts). </details> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: sethkfman <[email protected]> Co-authored-by: sethkfman <[email protected]>
Bumps [ip](https://github.com/indutny/node-ip) from 1.1.5 to 1.1.9. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/indutny/node-ip/commit/1ecbf2fd8c0cc85e44c3b587d2de641f50dc0217"><code>1ecbf2f</code></a> 1.1.9</li> <li><a href="https://github.com/indutny/node-ip/commit/6a3ada9b471b09d5f0f5be264911ab564bf67894"><code>6a3ada9</code></a> lib: fixed CVE-2023-42282 and added unit test</li> <li><a href="https://github.com/indutny/node-ip/commit/5dc3b2f3f4b4690fa9a918fa5085b6fca9979fca"><code>5dc3b2f</code></a> 1.1.8</li> <li><a href="https://github.com/indutny/node-ip/commit/8e6f28b23a89245eeac74ad2ef9eb0d27cb27e1c"><code>8e6f28b</code></a> lib: even better node 6 support</li> <li><a href="https://github.com/indutny/node-ip/commit/088c9e5664e43cda2a43c1e5b4acf921bb6613a9"><code>088c9e5</code></a> 1.1.7</li> <li><a href="https://github.com/indutny/node-ip/commit/1a4ca35ddc55d2987bb1a7e38e9a729a59174611"><code>1a4ca35</code></a> lib: add back support for Node.js 6</li> <li><a href="https://github.com/indutny/node-ip/commit/af82ef42adc513b20f7d1213421ca4b901d10f3d"><code>af82ef4</code></a> 1.1.6</li> <li><a href="https://github.com/indutny/node-ip/commit/dba19f6c0c6560bbc5bc18ad12976005900def87"><code>dba19f6</code></a> package: exclude test folder from publishing</li> <li><a href="https://github.com/indutny/node-ip/commit/7cd7f30991363d818cb0c6718a1ad5473c795b12"><code>7cd7f30</code></a> ci: use github workflows</li> <li><a href="https://github.com/indutny/node-ip/commit/4de50aec875d12b004849e11e19d6daf68b50c2d"><code>4de50ae</code></a> lib: node 18 support</li> <li>See full diff in <a href="https://github.com/indutny/node-ip/compare/v1.1.5...v1.1.9">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/MetaMask/metamask-mobile/network/alerts). </details> > **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days. --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: legobeat <[email protected]> Co-authored-by: sethkfman <[email protected]> Co-authored-by: sethkfman <[email protected]>
## **Description** This PR adds a display of a deprecation warning when a user switches to MUMBAI network ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to settings => network => add network => Custom networks 2. Fill in inputs: Name:Mumbai; RPC_URL:https://80001.rpc.thirdweb.com; chainId: 80001; Symbol: MATIC 3. Switch to this network 4. You should be able to see a deprecation warning "This network is deprecated" ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** https://github.com/MetaMask/metamask-mobile/assets/10994169/2aac6cf6-b884-4dac-8505-647ce2fabf35 ### **After** https://github.com/MetaMask/metamask-mobile/assets/10994169/1ca57d35-d415-4aa5-b6e8-383973f848cd ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
This reverts commit 6e87690. ## **Description** Revert Update controller utils to 5.0.2 The controller util dependency of network controller v12 is on v4 and it's not getting the patch with linea sepolia code applied, which makes updating the controller utils dependent of network controller v13 update, for simplicity we will revert this [PR](#9079) and then merge it after network controller v13 [PR](#9065) is merged ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** https://github.com/MetaMask/metamask-mobile/assets/46944231/6e3ce0e2-ad7e-444d-b496-58822da3ad8f Sendflow & dapp transaction https://github.com/MetaMask/metamask-mobile/assets/46944231/38ea2ccd-b3f1-48d5-b867-00c5d7cb0507 ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
## **Description** - Upgrade SDK communication layer to 0.18.1 - Upgrade WalletConnect SE sdk to 1.7.1 - Add `metamask_open` rpc call support to open different experiences on the wallet such as onramp and swap directly from the sdk. ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Omridan159 <[email protected]> Co-authored-by: Xiaoming Wang <[email protected]> Co-authored-by: Sébastien Van Eyck <[email protected]> Co-authored-by: Nico MASSART <[email protected]>
## **Description** Porting [this core PR](https://github.com/MetaMask/core/pull/3917/files) to mobile. ## **Related issues** Fixes an issue where the NFT detection controller was running too many times. It would send an HTTP request to fetch NFTs when any setting changed. It should only do so when the autodetect NFT setting changes. ## **Manual testing steps** 1. Open account with NFTs on mainnet 2. Verify they're still autodetected when the setting is on ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** https://github.com/MetaMask/metamask-mobile/assets/3500406/bf9ea063-88f8-4712-a426-97c0f23c49b4 ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Update dependabot.yml to use new [team-mobile-platform](https://github.com/MetaMask/metamask-mobile/labels/team-mobile-platform) label Fixes wrong team label in Dependabot PRs
Bumps [chromedriver](https://github.com/giggio/node-chromedriver) from 99.0.0 to 123.0.1. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/giggio/node-chromedriver/commit/26b10d13a5bfd1d9eeaeb4f6478e0db3a30accf6"><code>26b10d1</code></a> Bump version to 123.0.1</li> <li><a href="https://github.com/giggio/node-chromedriver/commit/6b707c6338b8737a051b2e6aff933211627b4430"><code>6b707c6</code></a> Bump version to 123.0.0</li> <li><a href="https://github.com/giggio/node-chromedriver/commit/242231426273d471685457d29df730707092e117"><code>2422314</code></a> Bump follow-redirects from 1.15.5 to 1.15.6</li> <li><a href="https://github.com/giggio/node-chromedriver/commit/ec269cf3acbb09a74bc6a15138de31af5b9be3c0"><code>ec269cf</code></a> Bump version to 122.0.6</li> <li><a href="https://github.com/giggio/node-chromedriver/commit/c6e01a4540202eb5d49ff02c6ed5d45cb864b606"><code>c6e01a4</code></a> Bump version to 122.0.5</li> <li><a href="https://github.com/giggio/node-chromedriver/commit/f4a0d7bd0be6b64d08b97e861bd1d4270cd09595"><code>f4a0d7b</code></a> Bump version to 122.0.4</li> <li><a href="https://github.com/giggio/node-chromedriver/commit/91bf14b4d3214c3cca9e655f9b035f4f6e4c0703"><code>91bf14b</code></a> Bump version to 122.0.3</li> <li><a href="https://github.com/giggio/node-chromedriver/commit/c91fa59595ca031d517e5ae41fbad2b002196e89"><code>c91fa59</code></a> Add tests and report on github actions</li> <li><a href="https://github.com/giggio/node-chromedriver/commit/2cfb625a9124a929f2e2f0485241727aca6211e6"><code>2cfb625</code></a> Update dependencies and change proxy impl</li> <li><a href="https://github.com/giggio/node-chromedriver/commit/6c14fa780aeea39dc066ca9e45d8a85dd58c9af7"><code>6c14fa7</code></a> Use metadata endpoint to find DL url</li> <li>Additional commits viewable in <a href="https://github.com/giggio/node-chromedriver/compare/99.0.0...123.0.1">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Nico MASSART <[email protected]>
Bumps [pify](https://github.com/sindresorhus/pify) from 4.0.1 to 6.1.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/sindresorhus/pify/releases">pify's releases</a>.</em></p> <blockquote> <h2>v6.1.0</h2> <ul> <li>Add TypeScript definitions (<a href="https://github-redirect.dependabot.com/sindresorhus/pify/issues/86">#86</a>) e13efc7</li> </ul> <p><a href="https://github.com/sindresorhus/pify/compare/v6.0.0...v6.1.0">https://github.com/sindresorhus/pify/compare/v6.0.0...v6.1.0</a></p> <h2>v6.0.0</h2> <h3>Breaking</h3> <ul> <li>Require Node.js 14 1f1b077</li> <li>This package is now pure ESM. <strong>Please <a href="https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c">read this</a>.</strong></li> </ul> <p><a href="https://github.com/sindresorhus/pify/compare/v5.0.0...v6.0.0">https://github.com/sindresorhus/pify/compare/v5.0.0...v6.0.0</a></p> <h2>v5.0.0</h2> <h3>Breaking</h3> <ul> <li>Require Node.js 10 a6c20b3</li> </ul> <h3>Enhancements</h3> <ul> <li>Implement using <a href="https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Proxy"><code>Proxy</code></a> (<a href="https://github-redirect.dependabot.com/sindresorhus/pify/issues/73">#73</a>) 57e9a04 This means that it should work seamlessly in more cases as the promisified function is just a transparent wrapper around the original function.</li> </ul> <p><a href="https://github.com/sindresorhus/pify/compare/v4.0.1...v5.0.0">https://github.com/sindresorhus/pify/compare/v4.0.1...v5.0.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/sindresorhus/pify/commit/749ba6ad3a5bf746dd9a780d914013764515e554"><code>749ba6a</code></a> 6.1.0</li> <li><a href="https://github.com/sindresorhus/pify/commit/7b70fd96c8c8567a929118e544fc6d00b1f8b640"><code>7b70fd9</code></a> Meta tweaks</li> <li><a href="https://github.com/sindresorhus/pify/commit/e13efc7ba68cc0a68fa17f0c31276159f56acdf7"><code>e13efc7</code></a> Add TypeScript definitions (<a href="https://github-redirect.dependabot.com/sindresorhus/pify/issues/86">#86</a>)</li> <li><a href="https://github.com/sindresorhus/pify/commit/513b0d57748e6f0a3eda4b14cbd0710a7fd2147e"><code>513b0d5</code></a> 6.0.0</li> <li><a href="https://github.com/sindresorhus/pify/commit/1f1b077fc2890ec3c5420503a517afeee106047d"><code>1f1b077</code></a> Require Node.js 14 and move to ESM</li> <li><a href="https://github.com/sindresorhus/pify/commit/6a2d954a6fb7fec670021dee4e9a37530956a472"><code>6a2d954</code></a> Move to GitHub Actions (<a href="https://github-redirect.dependabot.com/sindresorhus/pify/issues/83">#83</a>)</li> <li><a href="https://github.com/sindresorhus/pify/commit/671e01ee176df4300256666d77c3f3492ad39c84"><code>671e01e</code></a> Add FAQ section about binding class functions (<a href="https://github-redirect.dependabot.com/sindresorhus/pify/issues/80">#80</a>)</li> <li><a href="https://github.com/sindresorhus/pify/commit/5ef286ffc5310e7dbe99eee1891378ffde962ae9"><code>5ef286f</code></a> 5.0.0</li> <li><a href="https://github.com/sindresorhus/pify/commit/a6c20b396d06678055f1ac9b7aa8d5fcc4bdf836"><code>a6c20b3</code></a> Require Node.js 10</li> <li><a href="https://github.com/sindresorhus/pify/commit/57e9a0442e9e1224e73b844f1ed89b9bdbd10ec6"><code>57e9a04</code></a> Implement using Proxy (<a href="https://github-redirect.dependabot.com/sindresorhus/pify/issues/73">#73</a>)</li> <li>Additional commits viewable in <a href="https://github.com/sindresorhus/pify/compare/v4.0.1...v6.1.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days. --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Nico MASSART <[email protected]>
Bumps [es5-ext](https://github.com/medikoo/es5-ext) from 0.10.62 to 0.10.64. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/medikoo/es5-ext/releases">es5-ext's releases</a>.</em></p> <blockquote> <h2>0.10.64 (2024-02-27)</h2> <h3>Bug Fixes</h3> <ul> <li>Revert update to postinstall script meant to fix Powershell issue, as it's a regression for some Linux terminals (<a href="https://github.com/medikoo/es5-ext/commit/c2e2bb90c295c4c582445a6f03b2a3ad0b22550a">c2e2bb9</a>)</li> </ul> <hr /> <p><a href="https://github.com/medikoo/es5-ext/compare/v0.10.63...v0.10.64">Comparison since last release</a></p> <h2>0.10.63 (2024-02-23)</h2> <h3>Bug Fixes</h3> <ul> <li>Do not rely on problematic regex (<a href="https://github.com/medikoo/es5-ext/commit/3551cdd7b2db08b1632841f819d008757d28e8e2">3551cdd</a>), addresses <a href="https://redirect.github.com/medikoo/es5-ext/issues/201">#201</a></li> <li>Support ES2015+ function definitions in <code>function#toStringTokens()</code> (<a href="https://github.com/medikoo/es5-ext/commit/a52e95736690ad1d465ebcd9791d54570e294602">a52e957</a>), addresses <a href="https://redirect.github.com/medikoo/es5-ext/issues/021">#021</a></li> <li>Ensure postinstall script does not crash on Windows, fixes <a href="https://redirect.github.com/medikoo/es5-ext/issues/181">#181</a> (<a href="https://github.com/medikoo/es5-ext/commit/bf8ed799d57df53096da9d908ff577f305e1366f">bf8ed79</a>)</li> </ul> <h3>Maintenance Improvements</h3> <ul> <li>Simplify the manifest message (<a href="https://github.com/medikoo/es5-ext/commit/7855319f41b9736639cf4555bd2c419f17addf55">7855319</a>)</li> </ul> <hr /> <p><a href="https://github.com/medikoo/es5-ext/compare/v0.10.62...v0.10.63">Comparison since last release</a></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/medikoo/es5-ext/blob/main/CHANGELOG.md">es5-ext's changelog</a>.</em></p> <blockquote> <h3><a href="https://github.com/medikoo/es5-ext/compare/v0.10.63...v0.10.64">0.10.64</a> (2024-02-27)</h3> <h3>Bug Fixes</h3> <ul> <li>Revert update to postinstall script meant to fix Powershell issue, as it's a regression for some Linux terminals (<a href="https://github.com/medikoo/es5-ext/commit/c2e2bb90c295c4c582445a6f03b2a3ad0b22550a">c2e2bb9</a>)</li> </ul> <h3><a href="https://github.com/medikoo/es5-ext/compare/v0.10.62...v0.10.63">0.10.63</a> (2024-02-23)</h3> <h3>Bug Fixes</h3> <ul> <li>Do not rely on problematic regex (<a href="https://github.com/medikoo/es5-ext/commit/3551cdd7b2db08b1632841f819d008757d28e8e2">3551cdd</a>), addresses <a href="https://redirect.github.com/medikoo/es5-ext/issues/201">#201</a></li> <li>Support ES2015+ function definitions in <code>function#toStringTokens()</code> (<a href="https://github.com/medikoo/es5-ext/commit/a52e95736690ad1d465ebcd9791d54570e294602">a52e957</a>), addresses <a href="https://redirect.github.com/medikoo/es5-ext/issues/021">#021</a></li> <li>Ensure postinstall script does not crash on Windows, fixes <a href="https://redirect.github.com/medikoo/es5-ext/issues/181">#181</a> (<a href="https://github.com/medikoo/es5-ext/commit/bf8ed799d57df53096da9d908ff577f305e1366f">bf8ed79</a>)</li> </ul> <h3>Maintenance Improvements</h3> <ul> <li>Simplify the manifest message (<a href="https://github.com/medikoo/es5-ext/commit/7855319f41b9736639cf4555bd2c419f17addf55">7855319</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/medikoo/es5-ext/commit/f76b03d8c49ce4871f37f428c0e1d3ee6637fcc4"><code>f76b03d</code></a> chore: Release v0.10.64</li> <li><a href="https://github.com/medikoo/es5-ext/commit/2881acda50de0848b456690769919ed4b86be489"><code>2881acd</code></a> chore: Bump dependencies</li> <li><a href="https://github.com/medikoo/es5-ext/commit/c2e2bb90c295c4c582445a6f03b2a3ad0b22550a"><code>c2e2bb9</code></a> fix: Revert update meant to fix Powershell issue, as it's a regression</li> <li><a href="https://github.com/medikoo/es5-ext/commit/16f2b7253d3d8d499d8cf1d3ca76c585da7f08d3"><code>16f2b72</code></a> docs: Fix date in the changelog</li> <li><a href="https://github.com/medikoo/es5-ext/commit/de4e03c4776a303284142f73f3f181a070615817"><code>de4e03c</code></a> chore: Release v0.10.63</li> <li><a href="https://github.com/medikoo/es5-ext/commit/3fd53b755ec883be8f119c747f0b04130741e456"><code>3fd53b7</code></a> chore: Upgrade<code> lint-staged</code> to v13</li> <li><a href="https://github.com/medikoo/es5-ext/commit/bf8ed799d57df53096da9d908ff577f305e1366f"><code>bf8ed79</code></a> chore: Ensure postinstall script does not crash on Windows</li> <li><a href="https://github.com/medikoo/es5-ext/commit/2cbbb0717bd8de6e38fcba1f0d45bc876e7a1951"><code>2cbbb07</code></a> chore: Bump dependencies</li> <li><a href="https://github.com/medikoo/es5-ext/commit/22d0416ea170000a115609f22a560dfa9193ebb0"><code>22d0416</code></a> chore: Bump LICENSE year</li> <li><a href="https://github.com/medikoo/es5-ext/commit/a52e95736690ad1d465ebcd9791d54570e294602"><code>a52e957</code></a> fix: Support ES2015+ function definitions in <code>function#toStringTokens()</code></li> <li>Additional commits viewable in <a href="https://github.com/medikoo/es5-ext/compare/v0.10.62...v0.10.64">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/MetaMask/metamask-mobile/network/alerts). </details> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Nico MASSART <[email protected]>
Bumps [buffer](https://github.com/feross/buffer) from 5.2.1 to 6.0.3. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/feross/buffer/commit/088fd9709e95f96b1f64d1c55ed3c50a19c73e9f"><code>088fd97</code></a> 6.0.3</li> <li><a href="https://github.com/feross/buffer/commit/55269a70c50fdf9304b08a4eb190e173e1a8073a"><code>55269a7</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/feross/buffer/issues/277">#277</a> from martinheidegger/patch-1</li> <li><a href="https://github.com/feross/buffer/commit/7aa04d6951870fed0b021981963b48fabbc01660"><code>7aa04d6</code></a> Types: Using Uint8Array instead of Buffer</li> <li><a href="https://github.com/feross/buffer/commit/2b1286b3e0c61f22d68c9f7bdca2c11012d87dfe"><code>2b1286b</code></a> update authors</li> <li><a href="https://github.com/feross/buffer/commit/812808ac4a61e411b80dd2d93cc893f35c8f4065"><code>812808a</code></a> 6.0.2</li> <li><a href="https://github.com/feross/buffer/commit/dd36e96b79c3d106e0a9e7e43e608130d5a41f5a"><code>dd36e96</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/feross/buffer/issues/274">#274</a> from deklanw/master</li> <li><a href="https://github.com/feross/buffer/commit/a937c94f2975a470c0e7e983df6aac6ef6591ee8"><code>a937c94</code></a> Add BigInt operations to types</li> <li><a href="https://github.com/feross/buffer/commit/74899b7fbd0e3247931fa3cfb9fc27e96a995d21"><code>74899b7</code></a> update authors</li> <li><a href="https://github.com/feross/buffer/commit/0ba6c18d58f6d0fb5fa75030c1793a66bf8d98f2"><code>0ba6c18</code></a> 6.0.1</li> <li><a href="https://github.com/feross/buffer/commit/411bd9a88158c488c99b624882c563f777442c63"><code>411bd9a</code></a> avoid unnecessary buffer copy</li> <li>Additional commits viewable in <a href="https://github.com/feross/buffer/compare/v5.2.1...v6.0.3">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days. --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Nico MASSART <[email protected]>
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** translation PR for warning ticker ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
…ler (#9162) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** 1. What is the reason for the change? - the internal state of the accounts controller and the preferences controller was getting out of sync when editing the account names in the UI - this meant that the users preferred name was not reflected in the AccountsController - although there is currently no user impact because of this issue, it will lead to problems in the future and will require a new migration to be written in coming releases. 2. What is the improvement/solution? - Created a new Engine utility method called `setAccountLabel` (similar to what we are doing for `setSelectedAccount`) that changes both the PreferencesController and the AccountsController label. - Updated the use of `PreferencesController.setAccountLabel` in the UI to be `Engine.setAccountLabel` - added tests ## **Related issues** Fixes: N/A ## **Manual testing steps** 1. Create or import a wallet 2. add the following code block to the `useAccounts.ts` hook ```ts // TODO remove this useEffect before merging useEffect(() => { // eslint-disable-next-line no-console console.log( 'Accounts/ AccountController', JSON.stringify(Engine.context.AccountsController.state, null, 2), ); // eslint-disable-next-line no-console console.log( 'Accounts/ PreferencesController', JSON.stringify( Engine.context.PreferencesController.state.identities, null, 2, ), ); }, [ Engine.context.AccountsController.state, Engine.context.PreferencesController.identities, Engine.context.PreferencesController.state.identities, ]); ``` 3. reload the app and inspect the logs. the names and addresses should match 1:1 4. add an account via the account picker from the main wallet view 5. change the names of your accounts 6. refresh the wallet 7. all the account names should match along with the selected account 8. the state logged in the console should still match 1:1 **- Double check that there are NO other direct calls to other preferences controller methods like `PreferencesController.setAccountLabel`** ### **Before** - Notice different account names in each controller ```json Accounts/ AccountController { "internalAccounts": { "accounts": { "6ffaed06-b348-4fc1-a227-972de373effd": { "id": "6ffaed06-b348-4fc1-a227-972de373effd", "address": "0x4a29682b2636147f608cf7554f47bd9877117bdd", "options": {}, "methods": [ "personal_sign", "eth_sign", "eth_signTransaction", "eth_signTypedData_v1", "eth_signTypedData_v3", "eth_signTypedData_v4" ], "type": "eip155:eoa", "metadata": { "name": "Account 1", "keyring": { "type": "HD Key Tree" }, "lastSelected": 1712528808432 } }, "59e23a68-b6b7-43a8-90f8-7236f748fe00": { "id": "59e23a68-b6b7-43a8-90f8-7236f748fe00", "address": "0x769dde14f7d7d48ed431d727801620f46d7ae29e", "options": {}, "methods": [ "personal_sign", "eth_sign", "eth_signTransaction", "eth_signTypedData_v1", "eth_signTypedData_v3", "eth_signTypedData_v4" ], "type": "eip155:eoa", "metadata": { "name": "Account 2", "keyring": { "type": "HD Key Tree" }, "lastSelected": 1712528808551 } }, "04cc2134-f9f6-4a42-b07b-3ebc40078f4f": { "id": "04cc2134-f9f6-4a42-b07b-3ebc40078f4f", "address": "0x9351164ed35ace26f345f749b9cb85b5c699e2b7", "options": {}, "methods": [ "personal_sign", "eth_sign", "eth_signTransaction", "eth_signTypedData_v1", "eth_signTypedData_v3", "eth_signTypedData_v4" ], "type": "eip155:eoa", "metadata": { "name": "Account 3", "keyring": { "type": "HD Key Tree" }, "lastSelected": 1712528808747 } } }, "selectedAccount": "04cc2134-f9f6-4a42-b07b-3ebc40078f4f" } } LOG Accounts/ PreferencesController { "0x4A29682b2636147F608CF7554F47bd9877117bDd": { "address": "0x4A29682b2636147F608CF7554F47bd9877117bDd", "name": "Account 1", "importTime": 1712527955387 }, "0x769ddE14f7D7D48eD431d727801620F46d7aE29e": { "address": "0x769ddE14f7D7D48eD431d727801620F46d7aE29e", "name": "Cool 2", "importTime": 1712528157517 }, "0x9351164ED35aCe26F345F749B9Cb85b5C699E2b7": { "address": "0x9351164ED35aCe26F345F749B9Cb85b5C699E2b7", "name": "Gyro 3", "importTime": 1712528160433 } } ``` ### **After** - Notice that the account names in both controllers match ```json Accounts/ AccountController { "internalAccounts": { "accounts": { "6ffaed06-b348-4fc1-a227-972de373effd": { "id": "6ffaed06-b348-4fc1-a227-972de373effd", "address": "0x4a29682b2636147f608cf7554f47bd9877117bdd", "options": {}, "methods": [ "personal_sign", "eth_sign", "eth_signTransaction", "eth_signTypedData_v1", "eth_signTypedData_v3", "eth_signTypedData_v4" ], "type": "eip155:eoa", "metadata": { "name": "Cool Account 1", "keyring": { "type": "HD Key Tree" }, "lastSelected": 1712575526370 } }, "59e23a68-b6b7-43a8-90f8-7236f748fe00": { "id": "59e23a68-b6b7-43a8-90f8-7236f748fe00", "address": "0x769dde14f7d7d48ed431d727801620f46d7ae29e", "options": {}, "methods": [ "personal_sign", "eth_sign", "eth_signTransaction", "eth_signTypedData_v1", "eth_signTypedData_v3", "eth_signTypedData_v4" ], "type": "eip155:eoa", "metadata": { "name": "Cool Account 2", "keyring": { "type": "HD Key Tree" }, "lastSelected": 1712575539858 } }, "04cc2134-f9f6-4a42-b07b-3ebc40078f4f": { "id": "04cc2134-f9f6-4a42-b07b-3ebc40078f4f", "address": "0x9351164ed35ace26f345f749b9cb85b5c699e2b7", "options": {}, "methods": [ "personal_sign", "eth_sign", "eth_signTransaction", "eth_signTypedData_v1", "eth_signTypedData_v3", "eth_signTypedData_v4" ], "type": "eip155:eoa", "metadata": { "name": "Cool Account 3", "keyring": { "type": "HD Key Tree" }, "lastSelected": 1712575552843 } } }, "selectedAccount": "04cc2134-f9f6-4a42-b07b-3ebc40078f4f" } } LOG Accounts/ PreferencesController { "0x4A29682b2636147F608CF7554F47bd9877117bDd": { "address": "0x4A29682b2636147F608CF7554F47bd9877117bDd", "name": "Cool Account 1", "importTime": 1712527955387 }, "0x769ddE14f7D7D48eD431d727801620F46d7aE29e": { "address": "0x769ddE14f7D7D48eD431d727801620F46d7aE29e", "name": "Cool Account 2", "importTime": 1712528157517 }, "0x9351164ED35aCe26F345F749B9Cb85b5C699E2b7": { "address": "0x9351164ED35aCe26F345F749B9Cb85b5C699E2b7", "name": "Cool Account 3", "importTime": 1712528160433 } } ``` ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
## **Description**
The variable `newlySelectedInternalAccount.address`, that was being
returned by the `AccountsController:selectedAccountChange` event was on
a lowercase format. We were duplicating the accounts, so one account was
checksummed and another not, which was making the tokens be on storage
but not showing because the new selected account was not with tokens
imported.
This is a how the data storage was:
```
{"allDetectedTokens": {"0x1": {"0x2990079bcdEe240329a520d2444386FC119da21a": [Array]}, "0xa86a": {"0x2990079bcdEe240329a520d2444386FC119da21a": [Array], "0x2990079bcdee240329a520d2444386fc119da21a": [Array]}}, "allIgnoredTokens": {}, "allTokens": {"0xa86a": {"0x2990079bcdEe240329a520d2444386FC119da21a": [Array]}}, "detectedTokens": [{"address": "0x9702230A8Ea53601f5cD2dc00fDBc13d4dF4A8c7", "aggregators": [Array], "decimals": 6, "image": "https://static.metafi.codefi.network/api/v1/tokenIcons/43114/0x9702230a8ea53601f5cd2dc00fdbc13d4df4a8c7.png", "isERC721": false, "name": "TetherToken", "symbol": "USDT"}, {"address": "0xB97EF9Ef8734C71904D8002F8b6Bc66Dd9c48a6E", "aggregators": [Array], "decimals": 6, "image": "https://static.metafi.codefi.network/api/v1/tokenIcons/43114/0xb97ef9ef8734c71904d8002f8b6bc66dd9c48a6e.png", "isERC721": false, "name": "USD Coin", "symbol": "USDC"}, {"address": "0xB31f66AA3C1e785363F0875A1B74E27b85FD66c7", "aggregators": [Array], "decimals": 18, "image": "https://static.metafi.codefi.network/api/v1/tokenIcons/43114/0xb31f66aa3c1e785363f0875a1b74e27b85fd66c7.png", "isERC721": false, "name": "Wrapped AVAX", "symbol": "WAVAX"}, {"address": "0x49D5c2BdFfac6CE2BFdB6640F4F80f226bc10bAB", "aggregators": [Array], "decimals": 18, "image": "https://static.metafi.codefi.network/api/v1/tokenIcons/43114/0x49d5c2bdffac6ce2bfdb6640f4f80f226bc10bab.png", "isERC721": false, "name": "Wrapped Ether", "symbol": "WETH.E"}, {"address": "0x50b7545627a5162F82A992c33b87aDc75187B218", "aggregators": [Array], "decimals": 8, "image": "https://static.metafi.codefi.network/api/v1/tokenIcons/43114/0x50b7545627a5162f82a992c33b87adc75187b218.png", "isERC721": false, "name": "Wrapped BTC", "symbol": "WBTC.E"}, {"address": "0x63a72806098Bd3D9520cC43356dD78afe5D386D9", "aggregators": [Array], "decimals": 18, "image": "https://static.metafi.codefi.network/api/v1/tokenIcons/43114/0x63a72806098bd3d9520cc43356dd78afe5d386d9.png", "isERC721": false, "name": "Aave Token", "symbol": "AAVE.E"}, {"address": "0x8b82A291F83ca07Af22120ABa21632088fC92931", "aggregators": [Array], "decimals": 18, "image": "https://static.metafi.codefi.network/api/v1/tokenIcons/43114/0x8b82a291f83ca07af22120aba21632088fc92931.png", "isERC721": false, "name": "Ethereum Wormhole ", "symbol": "ETH"}, {"address": "0x120AD3e5A7c796349e591F1570D9f7980F4eA9cb", "aggregators": [Array], "decimals": 6, "image": "https://static.metafi.codefi.network/api/v1/tokenIcons/43114/0x120ad3e5a7c796349e591f1570d9f7980f4ea9cb.png", "isERC721": false, "name": "Axelar Wrapped LUNA", "symbol": "LUNA"}], "ignoredTokens": [], "tokens": []}
```
This is how it is now:
```
{
"allDetectedTokens":{
"0x1":{
"0x2990079bcdEe240329a520d2444386FC119da21a":[
"Array"
]
},
"0xa86a":{
"0x2990079bcdEe240329a520d2444386FC119da21a":[
"Array"
]
}
},
"allIgnoredTokens":{
},
"allTokens":{
"0xa86a":{
"0x2990079bcdEe240329a520d2444386FC119da21a":[
"Array"
]
}
},
"detectedTokens":[
],
"ignoredTokens":[
],
"tokens":[
{
"address":"0x9702230A8Ea53601f5cD2dc00fDBc13d4dF4A8c7",
"aggregators":[
"Array"
],
"balanceError":null,
"decimals":6,
"image":"https://static.metafi.codefi.network/api/v1/tokenIcons/43114/0x9702230a8ea53601f5cd2dc00fdbc13d4df4a8c7.png",
"name":"TetherToken",
"symbol":"USDT"
},
{
"address":"0xB97EF9Ef8734C71904D8002F8b6Bc66Dd9c48a6E",
"aggregators":[
"Array"
],
"balanceError":null,
"decimals":6,
"image":"https://static.metafi.codefi.network/api/v1/tokenIcons/43114/0xb97ef9ef8734c71904d8002f8b6bc66dd9c48a6e.png",
"name":"USD Coin",
"symbol":"USDC"
},
{
"address":"0xB31f66AA3C1e785363F0875A1B74E27b85FD66c7",
"aggregators":[
"Array"
],
"balanceError":null,
"decimals":18,
"image":"https://static.metafi.codefi.network/api/v1/tokenIcons/43114/0xb31f66aa3c1e785363f0875a1b74e27b85fd66c7.png",
"name":"Wrapped AVAX",
"symbol":"WAVAX"
},
{
"address":"0x49D5c2BdFfac6CE2BFdB6640F4F80f226bc10bAB",
"aggregators":[
"Array"
],
"balanceError":null,
"decimals":18,
"image":"https://static.metafi.codefi.network/api/v1/tokenIcons/43114/0x49d5c2bdffac6ce2bfdb6640f4f80f226bc10bab.png",
"name":"Wrapped Ether",
"symbol":"WETH.E"
},
{
"address":"0x50b7545627a5162F82A992c33b87aDc75187B218",
"aggregators":[
"Array"
],
"balanceError":null,
"decimals":8,
"image":"https://static.metafi.codefi.network/api/v1/tokenIcons/43114/0x50b7545627a5162f82a992c33b87adc75187b218.png",
"name":"Wrapped BTC",
"symbol":"WBTC.E"
},
{
"address":"0x63a72806098Bd3D9520cC43356dD78afe5D386D9",
"aggregators":[
"Array"
],
"balanceError":null,
"decimals":18,
"image":"https://static.metafi.codefi.network/api/v1/tokenIcons/43114/0x63a72806098bd3d9520cc43356dd78afe5d386d9.png",
"name":"Aave Token",
"symbol":"AAVE.E"
},
{
"address":"0x8b82A291F83ca07Af22120ABa21632088fC92931",
"aggregators":[
"Array"
],
"balanceError":null,
"decimals":18,
"image":"https://static.metafi.codefi.network/api/v1/tokenIcons/43114/0x8b82a291f83ca07af22120aba21632088fc92931.png",
"name":"Ethereum Wormhole ",
"symbol":"ETH"
},
{
"address":"0x120AD3e5A7c796349e591F1570D9f7980F4eA9cb",
"aggregators":[
"Array"
],
"balanceError":null,
"decimals":6,
"image":"https://static.metafi.codefi.network/api/v1/tokenIcons/43114/0x120ad3e5a7c796349e591f1570d9f7980f4ea9cb.png",
"name":"Axelar Wrapped LUNA",
"symbol":"LUNA"
}
]
}
```
## **Related issues**
Fixes: #9122
## **Manual testing steps**
1. Go to uniswap, pancake swap, open sea
2. Connect with those dapps
3. Disconnected with those dapps
4. Performed a swap on uniswap on avalanche and binance smart chain
## **Screenshots/Recordings**
Upgrade path recording:
Uploading Screen Recording 2024-04-05 at 13.14.41.mov…
### **Before**
<!-- [screenshots/recordings] -->
### **After**
<!-- [screenshots/recordings] -->
## **Pre-merge author checklist**
- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR addresses regression with permission system integration and wallet connect issues regarding switching chains. - WC: Add loading screen while establishing connection. - WC: Add "Go Back to Dapp" modal on deeplinks for improved ux. **PENDING** videos from wc showing previous issues ## **Related issues** Fixes: issues on some RPC calls that could potentially return an empty list of account instead of the one that were permitted. ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
change tracking mode to anonymous for CUSTOM_TOKEN_IMPORTED Fixes #9163
Contributor Experience improvement Reference Xcode configuration required to build in the `docs/environment.md`. Xocde needs to be opened, install simulators, and then select the corresponding command line tools to successfully build for iOS
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- --> Updated Signature Controller to version 6.0.0. Removed keyringController property from constructor in Engine.ts e2e Tests: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1539b3e5-c224-4987-9b1f-62e479c4de19 ## **Related issues** Fixes: MetaMask/mobile-planning#1613 ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** https://github.com/MetaMask/metamask-mobile/assets/15312578/148257f7-b8ea-418c-881b-bd73f0caeb5c ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
… APIs (#9124) ## **Description** This PR adds a new privacy file identifying why the app is using specific privacy APIs. These mentions in the manifest: - NSPrivacyAccessedAPICategoryFileTimestamp - Display Activity Times - NSPrivacyAccessedAPICategoryDiskSpace - Download files - NSPrivacyAccessedAPICategorySystemBootTime - Sentry Times - NSPrivacyAccessedAPICategoryUserDefaults - MMKV Are the modules/functions that are associated with the required declarations in the manifest. Sentry was also updated due to bug with duplicate [Privacy Manifests in older versions](getsentry/sentry-react-native#3599). ## **Related issues** [Fixes](MetaMask/mobile-planning#1424) ## **Manual testing steps** 1. Submit new app to TestFlight 2. See there are now errors in privacy audit ## **Screenshots/Recordings** ### **Before** <img width="882" alt="Screenshot 2024-04-05 at 12 39 25 PM" src="https://github.com/MetaMask/metamask-mobile/assets/10342624/56b59718-366e-4365-b854-5cd120d07544"> ### **After** <img width="744" alt="Screenshot 2024-04-04 at 12 31 53 PM" src="https://github.com/MetaMask/metamask-mobile/assets/10342624/3a0e9a15-624f-4fb6-8050-ecdb5110523f"> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Pedro Pablo Aste Kompen <[email protected]>
## **Description** - Update we-sdk to fix missing chainId on cold start - Fix: "return to dapp" modal not displayed on new session proposal after disconnect ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This change adds a 'Stake' button link to the Portfolio stake page next to the ETH token on mainnet. The reason for this change is to have parity with the extension, give users easier access to MM Staking, and drive revenue. ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/STAKE-629 Request template: https://www.notion.so/metamask-consensys/Add-Stake-Button-to-Mobile-f160ebc0f6b6437c9b3d0f943851771a ## **Manual testing steps** - Go to Token Listing - Verify that the new staking icon shows on for ETH mainnet - Verify that the new staking icon doesn't show on any other token than ETH, and not on any other chain than mainnet - Verify that onPress, the MM browser opens up the Portfolio stake page with the correct query params - Verify that if a browser tab is already open on the stake page, the MM browser picks this tab rather than opening a new one ## **Screenshots/Recordings** https://github.com/MetaMask/metamask-mobile/assets/22345430/9571eefa-9212-4135-9da6-1bb56dab576f ### **Before** <img width="351" alt="image" src="https://github.com/MetaMask/metamask-mobile/assets/22345430/5e57c135-7fa9-42a0-a6a8-702f66c7fe3e"> ### **After** <img width="349" alt="image" src="https://github.com/MetaMask/metamask-mobile/assets/22345430/2c7a5896-1357-43fe-be6c-be7ad7064f5a"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
### Contributor experience improvement - Simplify `yarn setup` logs. - Make errors evident by displaying which task failed and what was the problem. - Create a foundation to extend the setup script to help turn environment setup into a builtin interactive process. New Dependencies: - update execa to v8.x.x. [New API support](https://github.com/sindresorhus/execa/blob/main/docs/scripts.md) - add listr2, a [task list for the terminal](https://listr2.kilic.dev/) ## **Screenshots/Recordings** Success setup  Setup with error  CI non-TTY output <img width="358" alt="image" src="https://github.com/MetaMask/metamask-mobile/assets/1649425/325fcc68-9e03-4338-be9e-5b9bd08be911"> Co-authored-by: sethkfman <[email protected]>
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** We are updating the popular networks list each quarter based on usage found on the array below: <img width="575" alt="Screenshot 2024-04-10 at 17 25 52" src="https://github.com/MetaMask/metamask-mobile/assets/26223211/1743723e-5049-4e50-a306-6c3402dbc94d"> Todo now ( on this PR ) - network fantom and harmony removed, network base and zk-synv era mainnet added. - Avalanche should use infura RPC - Palm network should be removed for scroll , zetachain and opBNB mainnet , we work with infura and need to source them with DIN , once this is done we'll integrate them as a popular network in a second PR Berachain Artio is a testnet ( you can skip it ) ## **Related issues** Fixes: #9160 ## **Manual testing steps** 1. Go to the add network modal and click on add network 2. check the list of popular network ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <img width="464" alt="popular-before" src="https://github.com/MetaMask/metamask-mobile/assets/26223211/eb748518-5eef-4d2c-84ab-fe73b3ccf129"> ### **After**   ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
## **Description** Updated network controller to version 13.0.1. Also created migration to delete networkId property from the network controller state Added an inpageProvider property with a network id property to our internal property, Created the reducer and the action for that property with createSlice of redux toolkit Added dispatch to the engine event subscriber `networkdStateChange` to update networkId Added dispatch to the Engine file with subscribing an event `networkWillChange` to update networkId to "loading" Updated the patch of network controller Updated test cases and initial states with new data structure with the networkId property ## **Related issues** Fixes MetaMask/mobile-planning#1624 ## **Manual testing steps** QA Build: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4b1752b4-2490-4eee-b0f9-68a347562ccd 1. Go to this page... 2. 3. ## **Screenshots/Recordings** https://github.com/MetaMask/metamask-mobile/assets/46944231/7d80d89e-8c4c-485e-8806-65e11419934e Latest recording with new actions (while updating migration from main with account imported on optimism) https://github.com/MetaMask/metamask-mobile/assets/46944231/d290680a-ae53-4f3e-b752-1ded27964954 ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR fixes missing pod updates from a PR with notifications changes #8701 This updates both the Xcode project file as well as Podfile.lock cc: @Jonathansoufer ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Cal-L
force-pushed
the
chore/7.20.0-merge-from-main
branch
from
3bd2c53 to
102b6d2
Compare
|
All changes are from merge @SocketSecurity ignore-all |
|
@SocketSecurity ignore-all |
Cal-L
added
Run Smoke E2E
|
Cal-L
added
Run Smoke E2E
Cal-L
added
Run Smoke E2E
|
|
github-actions
bot
removed
the
needs-dev-review
metamaskbot
added
the
release-7.20.0
|
No release label on PR. Adding release label release-7.20.0 on PR, as PR was added to branch 7.20.0 when release was cut. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merge
mainintorelease/7.20.0Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist