chore: cherry pick 7881 #7883
Merged
chore: cherry pick 7881 #7883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## **Description** This PR was created to fix the issue [#7862], following code change has been done: 1. Change the `getKeyringByAddress()` method to return undefined when address is not valid hex address (e.g. ENS domain name) 2. Fix the existing unit tests to reflect above changes in `address/index.test.ts` file 3. add extra unit tests to make sure function will return undefined when address is not valid hex address (e.g. ENS domain) ## **Related issues** Fixes: [#7862] ## **Manual testing steps** Please refer to following videos for detail how to test. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** https://github.com/MetaMask/metamask-mobile/assets/7315988/2c61515b-df26-460f-b2da-93fe6902e004 ### **After** https://github.com/MetaMask/metamask-mobile/assets/7315988/f8cf64bb-e323-452f-99be-0c3ffc99592f - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [x] I've included manual testing steps - [x] I've included screenshots/recordings if applicable - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I’ve properly set the pull request status: - [x] In case it's not yet "ready for review", I've set it to "draft". - [x] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: sethkfman <[email protected]> Co-authored-by: Gustavo Antunes <[email protected]>
sethkfman
added
type-bug
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/46e37cc6-b4e3-4b92-b4e4-0107e0a45166 |
|
Kudos, SonarCloud Quality Gate passed! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/7.12.0 #7883 +/- ##
===============================================
Coverage 37.38% 37.38%
===============================================
Files 1052 1052
Lines 28177 28177
Branches 2516 2516
===============================================
Hits 10534 10534
Misses 17044 17044
Partials 599 599 ☔ View full report in Codecov by Sentry. |
chrisleewilcox
added
the
regression-RC
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR was created to fix the issue [#7862], following code change has been done:
getKeyringByAddress()method to return undefined when address is not valid hex address (e.g. ENS domain name)address/index.test.tsfileRelated issues
Fixes: [#7862]
Manual testing steps
Please refer to following videos for detail how to test.
Screenshots/Recordings
Before
before.mp4
After
Screen_Recording_20231120_224005_MetaMask.mp4
Pre-merge reviewer checklist
Description
Related issues
Fixes: #
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist