Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove unused package #13395

Merged
merged 1 commit into from
Feb 13, 2025
Merged

feat: remove unused package #13395

merged 1 commit into from
Feb 13, 2025

Conversation

Prithpal-Sooriya
Copy link
Contributor

Description

This is a cleanup since feature announcements are handled in CORE

Related issues

Fixes:

Manual testing steps

NA since notifications aren't released

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Prithpal-Sooriya Prithpal-Sooriya requested review from a team as code owners February 6, 2025 19:38
@Prithpal-Sooriya Prithpal-Sooriya changed the base branch from main to refactor/cleanup-notification-types-and-constants February 6, 2025 19:38
Copy link
Contributor

github-actions bot commented Feb 6, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Prithpal-Sooriya Prithpal-Sooriya changed the title Chore/remove contentful chore: remove unused package Feb 6, 2025
Base automatically changed from refactor/cleanup-notification-types-and-constants to main February 7, 2025 10:01
this is a cleanup since feature announcements are handled in CORE
@Prithpal-Sooriya Prithpal-Sooriya added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 628b2dc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/95e25bc0-8fc1-4261-8668-59d3e0fa1a57

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarqubecloud bot commented Feb 7, 2025

@Prithpal-Sooriya Prithpal-Sooriya changed the title chore: remove unused package feat: remove unused package Feb 7, 2025
@Prithpal-Sooriya Prithpal-Sooriya added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 7, 2025
@Prithpal-Sooriya Prithpal-Sooriya added this pull request to the merge queue Feb 13, 2025
Merged via the queue into main with commit 9798e95 Feb 13, 2025
46 of 47 checks passed
@Prithpal-Sooriya Prithpal-Sooriya deleted the chore/remove-contentful branch February 13, 2025 13:34
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2025
@metamaskbot metamaskbot added the release-7.41.0 Issue or pull request that will be included in release 7.41.0 label Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.41.0 Issue or pull request that will be included in release 7.41.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants