Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cp-12.13.0 dependency version #30375

Merged
merged 2 commits into from
Feb 17, 2025
Merged

fix: cp-12.13.0 dependency version #30375

merged 2 commits into from
Feb 17, 2025

Conversation

itsyoboieltr
Copy link
Contributor

@itsyoboieltr itsyoboieltr commented Feb 17, 2025

Description

Open in GitHub Codespaces

Context here: https://consensys.slack.com/archives/C1L7H42BT/p1739789037475089

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4220

Manual testing steps

  1. yarn audit passes CI

Screenshots/Recordings

Not applicable

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@itsyoboieltr itsyoboieltr self-assigned this Feb 17, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-extension-platform Extension Platform team label Feb 17, 2025
Copy link

socket-security bot commented Feb 17, 2025

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] 🔁 npm/[email protected] None 0 120 kB indutny

View full report↗︎

@itsyoboieltr itsyoboieltr changed the title fix: dependency version fix: cp-12.13.0 dependency version Feb 17, 2025
salimtb
salimtb previously approved these changes Feb 17, 2025
@salimtb
Copy link
Contributor

salimtb commented Feb 17, 2025

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

Copy link
Member

@mikesposito mikesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@itsyoboieltr itsyoboieltr added this pull request to the merge queue Feb 17, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [ab252ed]
Page Load Metrics (1472 ± 46 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1328176814749345
domContentLoaded1318175614609244
load1326176914729546
domInteractive23126412914
backgroundConnect94918115
firstReactRender1383362512
getState44710126
initialActions01000
loadScripts930128810598038
setupStore564192010
uiStartup15582004168912158
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -78.53 KiB (-1.30%)
  • ui: 0 Bytes (0.00%)
  • common: -79.43 KiB (-0.85%)

Merged via the queue into main with commit 9f6f506 Feb 17, 2025
73 checks passed
@itsyoboieltr itsyoboieltr deleted the fix/deps branch February 17, 2025 20:23
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2025
@metamaskbot metamaskbot added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Feb 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.14.0 Issue or pull request that will be included in release 12.14.0 team-extension-platform Extension Platform team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants