Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "fix: Avoid nonce flicker when transaction is submitted" #30370

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

pedronfigueiredo
Copy link
Contributor

Reverts #30193

@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Feb 17, 2025
@pedronfigueiredo pedronfigueiredo self-assigned this Feb 17, 2025
@pedronfigueiredo pedronfigueiredo requested a review from a team as a code owner February 17, 2025 16:06
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Feb 17, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [49cef94]
Page Load Metrics (1633 ± 48 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14151846163310048
domContentLoaded1407179816089345
load14161844163310148
domInteractive25113452713
backgroundConnect976282311
firstReactRender136624178
getState56713157
initialActions01000
loadScripts974131211558742
setupStore65817178
uiStartup16512070185811153
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 114 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [5195acc]
Page Load Metrics (1932 ± 111 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint25522821533715343
domContentLoaded150622461899231111
load151122791932230111
domInteractive25174463215
backgroundConnect874412110
firstReactRender1590372612
getState586292411
initialActions00000
loadScripts10661674140418890
setupStore865202010
uiStartup179226382231235113
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 114 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@pedronfigueiredo pedronfigueiredo added this pull request to the merge queue Feb 18, 2025
Merged via the queue into main with commit 599a4b5 Feb 18, 2025
73 checks passed
@pedronfigueiredo pedronfigueiredo deleted the revert-30193-pnf/4140 branch February 18, 2025 10:49
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2025
@metamaskbot metamaskbot added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Feb 18, 2025
@sleepytanya
Copy link
Contributor

Issue #30352 and #30353 are fixed:

Nonce value is not carried over to another account:

another_acc_nonce.mov

After low nonce transaction the next transaction is created with the correct nonce:

next_tx_nonce.mov

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.14.0 Issue or pull request that will be included in release 12.14.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants