Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: auto-fix linting issues #30344

Closed
wants to merge 1 commit into from

Conversation

Prithpal-Sooriya
Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya commented Feb 14, 2025

Description

Auto-fixes linting warnings for:

  • react/jsx-boolean-value
  • react/jsx-curly-brace-presence

Open in GitHub Codespaces

Related issues

Fixes: N/A - this resolves lint warnings.

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [a10c885]
Page Load Metrics (1680 ± 44 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15631897168610048
domContentLoaded1556188016519445
load1560189316809244
domInteractive24127533115
backgroundConnect9114322512
firstReactRender156527189
getState45914147
initialActions01000
loadScripts1095143112008441
setupStore767242211
uiStartup17742152190710953
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -3 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@Prithpal-Sooriya Prithpal-Sooriya marked this pull request as ready for review February 14, 2025 19:48
@Prithpal-Sooriya Prithpal-Sooriya requested review from a team as code owners February 14, 2025 19:48
@Prithpal-Sooriya
Copy link
Contributor Author

This is not needed anymore since we have updated the ESLint TS ruleset.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants