Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove circular dependency in token-buttons.tsx #30299

Merged
merged 5 commits into from
Feb 19, 2025

Conversation

davidmurdoch
Copy link
Contributor

@davidmurdoch davidmurdoch commented Feb 13, 2025

This PR solves an issue with circular dependencies. It does not change the behavior of the application. It only rearranges functions/files to avoid circular references.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-extension-platform Extension Platform team label Feb 13, 2025
@davidmurdoch davidmurdoch changed the title refactor: remove circular dependency in token-buttons.tsx refactor: remove circular dependency in token-buttons.tsx Feb 13, 2025
@davidmurdoch davidmurdoch marked this pull request as ready for review February 13, 2025 15:59
@davidmurdoch davidmurdoch requested review from HowardBraham, dbrans and a team as code owners February 13, 2025 15:59
@metamaskbot
Copy link
Collaborator

Builds ready [5ce8a1b]
Page Load Metrics (1614 ± 70 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint43219411562297143
domContentLoaded14531899158813565
load14621964161414670
domInteractive23103442814
backgroundConnect87229199
firstReactRender1484402612
getState37016189
initialActions01000
loadScripts10261431115711455
setupStore55719199
uiStartup16682264186819392
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [0484420]
Page Load Metrics (1682 ± 51 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15471986168311354
domContentLoaded15371965165610751
load15471976168210751
domInteractive2497402110
backgroundConnect977272010
firstReactRender1491312512
getState46910147
initialActions00000
loadScripts1108150912049345
setupStore767212211
uiStartup17842414193916881
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@DDDDDanica
Copy link
Contributor

LGTM !

@davidmurdoch davidmurdoch added this pull request to the merge queue Feb 19, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [ace5329]
Page Load Metrics (1769 ± 101 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint24722581685390187
domContentLoaded14432193174020799
load149522461769210101
domInteractive226635126
backgroundConnect998292713
firstReactRender1372402512
getState45014136
initialActions01000
loadScripts10101665126017283
setupStore761192010
uiStartup165324912030224107
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Merged via the queue into main with commit fad21cd Feb 19, 2025
79 checks passed
@davidmurdoch davidmurdoch deleted the circles-token-buttons branch February 19, 2025 01:05
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2025
@metamaskbot metamaskbot added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Feb 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.14.0 Issue or pull request that will be included in release 12.14.0 team-extension-platform Extension Platform team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants