feat: integrate multichain assets rates controller to extension UI #30291

salimtb · 2025-02-13T10:13:16Z

Description

This PR aims to integrate the new multichainAssetsRatesControllers into the extension. To achieve this, an upgrade of the assets controller to version 49 is required. As a result, the target branch is set accordingly:
MetaMask PR #30250.

Related issues

Fixes:

Manual testing steps

open a flask build and add a solana account
check if the polling for the rates is running

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-02-13T10:13:30Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

app/scripts/metamask-controller.js

- Add `MultichainAssetsController` to the controller init list - Fix issues with `MultichainBalanceController` - Fix issues with `MultichainTransactionsController` - Revert type changes

...cripts/controller-init/messengers/multichain/multichain-assets-rates-controller-messenger.ts

app/scripts/controller-init/multichain/multichain-rates-assets-controller-init.ts

ui/selectors/multichain-assets-rates.ts

metamaskbot · 2025-02-14T19:25:04Z

Builds ready [04ae981]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1883 ± 64 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1642	2150	1881	129	62
		domContentLoaded	1580	2114	1848	128	62
		load	1643	2153	1883	133	64
		domInteractive	25	124	46	28	13
		backgroundConnect	10	70	30	20	10
		firstReactRender	16	75	33	23	11
		getState	6	59	24	21	10
		initialActions	0	45	2	10	5
		loadScripts	1136	1603	1370	109	52
		setupStore	8	59	19	17	8
		uiStartup	1856	2333	2135	141	68

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.33 KiB (0.02%)
ui: 0 Bytes (0.00%)
common: 49 Bytes (0.00%)

ui/selectors/multichain-assets-rates.ts

GuillaumeRx

You need to add the controller name here: https://github.com/MetaMask/metamask-extension/blob/main/app/scripts/controller-init/utils.ts#L39

You might want to wait for https://github.com/MetaMask/metamask-extension/pull/30301to land on main as it will create a merge conflict

app/scripts/controller-init/messengers/index.ts

app/scripts/controller-init/multichain/multichain-rates-assets-controller-init.test.ts

sahar-fehri · 2025-02-17T11:02:06Z

Can re-approve once conflicts are resolved after #30301

…oller

GuillaumeRx

Still missing the controller's name here: https://github.com/MetaMask/metamask-extension/blob/main/app/scripts/controller-init/utils.ts#L39

salimtb · 2025-02-17T13:47:25Z

You need to add the controller name here: https://github.com/MetaMask/metamask-extension/blob/main/app/scripts/controller-init/utils.ts#L39

You might want to wait for https://github.com/MetaMask/metamask-extension/pull/30301to land on main as it will create a merge conflict

resolved

app/scripts/controller-init/utils.ts

app/scripts/controller-init/messengers/index.ts

app/scripts/controller-init/messengers/multichain/index.ts

app/scripts/metamask-controller.js

app/scripts/controller-init/controller-list.ts

metamaskbot · 2025-02-17T14:48:28Z

Builds ready [ae46e89]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1513 ± 43 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1346	1769	1514	89	43
		domContentLoaded	1340	1753	1488	90	43
		load	1347	1767	1513	90	43
		domInteractive	22	101	43	24	11
		backgroundConnect	9	59	27	19	9
		firstReactRender	14	75	29	23	11
		getState	4	10	7	2	1
		initialActions	0	0	0	0	0
		loadScripts	954	1295	1076	84	41
		setupStore	5	52	10	10	5
		uiStartup	1496	2350	1743	178	85

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.35 KiB (0.02%)
ui: 0 Bytes (0.00%)
common: 49 Bytes (0.00%)

zone-live · 2025-02-17T16:20:20Z

ui/selectors/assets.ts

+ * @param state - Redux state object.
+ * @returns An object containing non-EVM assets per accounts.
+ */
+export function getAssetsRates(state: AssetsRatesState) {


Quick question, will this selector replace the existing getMultichainCoinRates
Asking because it's being used in the getMultichainConversionRate
cc @salimtb @ccharly

@zone-live The one you mentioned is limited to Native tokens, whereas the one in this PR supports both SPL tokens and Native tokens.
So, the answer is yes—if we need comprehensive data, including SPL tokens, we should use the one in this PR.

Thank you @salimtb 💪🏼

…oller

sahar-fehri and others added 14 commits February 11, 2025 16:58

fix: bump assets-controllers to v49

50802a2

Update LavaMoat policies

b1463f9

fix: dedupe

fb857ae

Update LavaMoat policies

4a453d1

fix: merge conflicts

54c75c9

fix: bump assets

db67847

fix: patch

607ca16

fix: fix yarn

66c944f

fix: fix test

98eebaa

Update LavaMoat policies

6fd1caa

fix: fix patch

70fabea

Update LavaMoat policies

7d4627d

Merge branch 'main' into feat/bump-assets-controller-49.0.0

9d28e99

Merge branch 'main' into feat/bump-assets-controller-49.0.0

91f130a

metamaskbot added the team-assets label Feb 13, 2025

GuillaumeRx requested changes Feb 13, 2025

View reviewed changes

app/scripts/metamask-controller.js Outdated Show resolved Hide resolved

sahar-fehri and others added 8 commits February 13, 2025 12:19

Merge branch 'main' into feat/bump-assets-controller-49.0.0

414eef1

fix: lint

550a15d

Merge branch 'main' into feat/bump-assets-controller-49.0.0

d27585b

Merge branch 'main' into feat/bump-assets-controller-49.0.0

855ff7e

[WIP] MultichainAssetsController init

209900a

Update multichain controllers init

51c7df5

- Add `MultichainAssetsController` to the controller init list - Fix issues with `MultichainBalanceController` - Fix issues with `MultichainTransactionsController` - Revert type changes

fix: integrate multichainAssetsRatesController

d8aa775

fix: fix after rebase

48aa482

salimtb force-pushed the salim/integrate-mutichain-assets-rates-controller branch from 6cd7757 to 48aa482 Compare February 13, 2025 15:52

fix: fix linter

ef32bf4

salimtb requested a review from GuillaumeRx February 13, 2025 16:11

GuillaumeRx requested changes Feb 13, 2025

View reviewed changes

fix: fix PR comments

f174ac4

fix: fix linter

04ae981

sahar-fehri reviewed Feb 17, 2025

View reviewed changes

ui/selectors/multichain-assets-rates.ts Outdated Show resolved Hide resolved

GuillaumeRx requested changes Feb 17, 2025

View reviewed changes

app/scripts/controller-init/messengers/index.ts Outdated Show resolved Hide resolved

app/scripts/controller-init/multichain/multichain-rates-assets-controller-init.test.ts Outdated Show resolved Hide resolved

sahar-fehri previously approved these changes Feb 17, 2025

View reviewed changes

salimtb added 2 commits February 17, 2025 12:39

fix: fix PR comments

60a2284

Merge branch 'main' into salim/integrate-mutichain-assets-rates-contr…

c629eb7

…oller

salimtb dismissed sahar-fehri’s stale review via c629eb7 February 17, 2025 13:28

fix: fix linter

942e8e9

GuillaumeRx requested changes Feb 17, 2025

View reviewed changes

fix: add controller name

415aa4c

salimtb requested a review from GuillaumeRx February 17, 2025 13:58

GuillaumeRx requested changes Feb 17, 2025

View reviewed changes

salimtb added 2 commits February 17, 2025 15:07

fix: sort alphabetically the added controller

ec00454

fix: sort initialisation

ae46e89

GuillaumeRx approved these changes Feb 17, 2025

View reviewed changes

sahar-fehri approved these changes Feb 17, 2025

View reviewed changes

GuillaumeRx added this pull request to the merge queue Feb 17, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 17, 2025

zone-live reviewed Feb 17, 2025

View reviewed changes

Merge branch 'main' into salim/integrate-mutichain-assets-rates-contr…

72519bf

…oller

salimtb added this pull request to the merge queue Feb 17, 2025

Merged via the queue into main with commit 1f4afda Feb 17, 2025
71 of 73 checks passed

salimtb deleted the salim/integrate-mutichain-assets-rates-controller branch February 17, 2025 17:29

github-actions bot locked and limited conversation to collaborators Feb 17, 2025

metamaskbot added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Feb 17, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: integrate multichain assets rates controller to extension UI #30291

feat: integrate multichain assets rates controller to extension UI #30291

salimtb commented Feb 13, 2025 •

edited by github-actions bot

Loading

github-actions bot commented Feb 13, 2025

metamaskbot commented Feb 14, 2025

GuillaumeRx left a comment

sahar-fehri commented Feb 17, 2025

GuillaumeRx left a comment

salimtb commented Feb 17, 2025

metamaskbot commented Feb 17, 2025

zone-live Feb 17, 2025 •

edited

Loading

salimtb Feb 17, 2025 •

edited

Loading

zone-live Feb 18, 2025

feat: integrate multichain assets rates controller to extension UI #30291

feat: integrate multichain assets rates controller to extension UI #30291

Conversation

salimtb commented Feb 13, 2025 • edited by github-actions bot Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Feb 13, 2025

metamaskbot commented Feb 14, 2025

GuillaumeRx left a comment

Choose a reason for hiding this comment

sahar-fehri commented Feb 17, 2025

GuillaumeRx left a comment

Choose a reason for hiding this comment

salimtb commented Feb 17, 2025

metamaskbot commented Feb 17, 2025

zone-live Feb 17, 2025 • edited Loading

Choose a reason for hiding this comment

salimtb Feb 17, 2025 • edited Loading

Choose a reason for hiding this comment

zone-live Feb 18, 2025

Choose a reason for hiding this comment

salimtb commented Feb 13, 2025 •

edited by github-actions bot

Loading

zone-live Feb 17, 2025 •

edited

Loading

salimtb Feb 17, 2025 •

edited

Loading