Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mmmultisrp 44 add hd srp index to segment events #30245

Closed

Conversation

PatrykLucka
Copy link
Contributor

@PatrykLucka PatrykLucka commented Feb 11, 2025

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@PatrykLucka PatrykLucka self-assigned this Feb 11, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@PatrykLucka PatrykLucka force-pushed the MMMULTISRP-44-add-hd-srp-index-to-segment-events branch from d353593 to 3f296cd Compare February 11, 2025 12:22
@metamaskbot metamaskbot added the team-mmi PRs from the MMI team label Feb 11, 2025
@PatrykLucka PatrykLucka force-pushed the MMMULTISRP-44-add-hd-srp-index-to-segment-events branch 9 times, most recently from 1d1ade9 to 8317571 Compare February 17, 2025 15:21
@metamaskbot
Copy link
Collaborator

Builds ready [8317571]
Page Load Metrics (1693 ± 136 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint145924581712295142
domContentLoaded142623991675282136
load143624051693284136
domInteractive23206503919
backgroundConnect85321147
firstReactRender1398382713
getState469202210
initialActions01000
loadScripts100717391212220106
setupStore77217199
uiStartup166526681967316152
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 546 Bytes (0.01%)
  • ui: 4.66 KiB (0.06%)
  • common: 560 Bytes (0.01%)

@PatrykLucka PatrykLucka force-pushed the MMMULTISRP-44-add-hd-srp-index-to-segment-events branch from 8317571 to 3d02988 Compare February 18, 2025 09:31
@metamaskbot
Copy link
Collaborator

Builds ready [3d02988]
Page Load Metrics (1843 ± 67 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint23020831754375180
domContentLoaded14652064180814369
load15142088184313967
domInteractive24573584
backgroundConnect1187372311
firstReactRender1595382612
getState593242512
initialActions00000
loadScripts10221539128712359
setupStore85913115
uiStartup170726622136231111
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 546 Bytes (0.01%)
  • ui: 4.66 KiB (0.06%)
  • common: 560 Bytes (0.01%)

@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-mmi PRs from the MMI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants