Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add funkichain logo #29949

Merged
merged 2 commits into from
Feb 7, 2025
Merged

fix: add funkichain logo #29949

merged 2 commits into from
Feb 7, 2025

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Jan 28, 2025

Description

Open in GitHub Codespaces

Related issues

Fixes: #29339

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Screenshot 2025-01-28 at 21 21 56 Screenshot 2025-01-28 at 21 22 02

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@salimtb salimtb marked this pull request as ready for review January 28, 2025 20:23
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [232d4a6]
Page Load Metrics (1647 ± 57 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint48518851589281135
domContentLoaded14931869162511555
load15041881164711857
domInteractive229534168
backgroundConnect105123157
firstReactRender1683382713
getState56416199
initialActions0523115
loadScripts1045132411669344
setupStore75812115
uiStartup16872185188513364
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 175 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [b83f07d]
Page Load Metrics (1781 ± 75 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15792167179116278
domContentLoaded15692108174815072
load15792115178115575
domInteractive2396382210
backgroundConnect1176322110
firstReactRender1898442713
getState588212311
initialActions01000
loadScripts11011577127913364
setupStore86418189
uiStartup176927132066256123
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 175 Bytes (0.00%)

@salimtb salimtb added this pull request to the merge queue Feb 7, 2025
Merged via the queue into main with commit 80134a1 Feb 7, 2025
72 checks passed
@salimtb salimtb deleted the fix/add-Funkichain-logo branch February 7, 2025 13:14
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2025
@metamaskbot metamaskbot added the release-12.13.0 Issue or pull request that will be included in release 12.13.0 label Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.13.0 Issue or pull request that will be included in release 12.13.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add network icon for Funkichain
4 participants