fix(multichain-account-service): fix Tron addresses not being generated for all BIP44 accounts #7010
+53
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ulissesferreira
force-pushed
the
NWNT-646-tron-addresses-are-not-generated-for-all-accounts
branch
from
571281b to
804dfda
Compare
ulissesferreira
force-pushed
the
NWNT-646-tron-addresses-are-not-generated-for-all-accounts
branch
from
804dfda to
567927b
Compare
zone-live
reviewed
Oct 30, 2025
| import type { EntropySourceId, KeyringAccount } from '@metamask/keyring-api'; | ||
| import { TrxAccountType, TrxScope } from '@metamask/keyring-api'; | ||
| import { KeyringAccountEntropyTypeOption } from '@metamask/keyring-api'; | ||
| // import { KeyringAccountEntropyTypeOption } from '@metamask/keyring-api'; |
There was a problem hiding this comment.
Lol i have it locally and didn't push
ulissesferreira
force-pushed
the
NWNT-646-tron-addresses-are-not-generated-for-all-accounts
branch
from
fbe9b1b to
5415155
Compare
zone-live
approved these changes
Oct 31, 2025
ccharly
approved these changes
Oct 31, 2025
ccharly
changed the title
ulissesferreira
deleted the
NWNT-646-tron-addresses-are-not-generated-for-all-accounts
branch
|
We forgot the changelog (I thought this was enforced by the CI, I'm a bit confused by that 😅) Anyway, @ulissesferreira can you please make another PR for this? |
ulissesferreira
added a commit
that referenced
this pull request
Oct 31, 2025
4 tasks
ulissesferreira
added a commit
that referenced
this pull request
Oct 31, 2025
ulissesferreira
added a commit
that referenced
this pull request
Oct 31, 2025
ulissesferreira
added a commit
that referenced
this pull request
Oct 31, 2025
ccharly
pushed a commit
that referenced
this pull request
Oct 31, 2025
## Explanation Forgotten changelog ## References #7010 ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs), highlighting breaking changes as necessary - [x] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Update `packages/multichain-account-service/CHANGELOG.md` to note a fix: TRX account creation now uses `groupIndex` instead of `derivationPath`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 94ccbb1. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
We have stopped using derivation paths for account creation, only using the field
groupIndex. We had made this change on the Snap side but we didn't really change the TronProvider to match.References
NWNT-646
Checklist
Note
Switch Tron account creation to index-based flow and wire discovery via KeyringClient, updating tests accordingly.
index-basedcreateAccounts, passingaddressType: Eoaandscope: Mainnet.assertIsBip44Account.discoverAccountsnow callsKeyringClient.discoverAccountsand then invokescreateAccountswithgroupIndex.TrxAccountProvider.test.ts):createAccountto accept{ index }and ensure idempotency bygroupIndex.discoverAccountsmock and routekeyring_discoverAccountsthroughSnapController:handleRequest.Written by Cursor Bugbot for commit 5415155. This will update automatically on new commits. Configure here.