Skip to content

Conversation

@ChingizMardanov
Copy link
Contributor

@ChingizMardanov ChingizMardanov commented Oct 27, 2025

Explanation

Bridge API used to have a noFee parameter that was changed to fee parameter. For some time api will support both, however to eventually sunset a less flexible noFee parameter controller had to be changed.

References

Associated bridge-api PR.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Switches bridge request parameter from boolean noFee to numeric fee and updates types, validators, fetch utils, tests, and changelog.

  • Bridge API parameter change (BREAKING)
    • Replace noFee with fee across request handling and feature overrides.
  • Types/Validators
    • Update QuoteRequest to fee?: number (remove noFee).
    • Update GenericQuoteRequestSchema to fee and associated enums/schemas.
  • Fetch utilities
    • Build query params with fee instead of noFee in formatQueryParams (fetch.ts).
  • Controller behavior
    • Feature flag overrides for FeatureId.PERPS now inject fee and preserve aggIds/bridgeIds in fetchQuotes.
  • Tests
    • Adjust expectations and titles to use fee and verify fee=0 in request URLs.
  • Changelog
    • Document breaking change under Unreleased.

Written by Cursor Bugbot for commit d0285e8. This will update automatically on new commits. Configure here.

micaelae
micaelae previously approved these changes Oct 28, 2025
@ChingizMardanov ChingizMardanov marked this pull request as ready for review October 29, 2025 18:03
@ChingizMardanov ChingizMardanov requested review from a team as code owners October 29, 2025 18:03
bfullam
bfullam previously approved these changes Oct 29, 2025
@ChingizMardanov ChingizMardanov dismissed stale reviews from bfullam and micaelae via c9fae63 October 30, 2025 13:30
@ChingizMardanov ChingizMardanov enabled auto-merge (squash) October 30, 2025 17:40
@ChingizMardanov ChingizMardanov merged commit 6aedb66 into main Oct 30, 2025
259 checks passed
@ChingizMardanov ChingizMardanov deleted the swaps3309-noFee-to-fee branch October 30, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants