change: set defi controller to refresh only one account #6944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
salimtb
reviewed
Oct 27, 2025
packages/assets-controllers/src/DeFiPositionsController/fetch-positions.ts
Show resolved
Hide resolved
salimtb
previously approved these changes
Oct 27, 2025
bergarces
force-pushed
the
defi-controller-changes
branch
from
4f7407c to
a3456b1
Compare
salimtb
previously approved these changes
Oct 27, 2025
bergarces
force-pushed
the
defi-controller-changes
branch
from
e30122d to
4076d85
Compare
salimtb
previously approved these changes
Oct 27, 2025
bergarces
force-pushed
the
defi-controller-changes
branch
from
052c435 to
26f7172
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
KeyringController:unlockedeventDraft PR for extension: MetaMask/metamask-extension#37215
Draft PR for mobile: MetaMask/metamask-mobile#21657
References
Related to https://consensyssoftware.atlassian.net/browse/ASSETS-1238
Checklist
Note
Limits DeFi position updates to the selected EVM address and wraps the API call with an 8s timeout and single retry.
AccountTreeController:getAccountsFromSelectedAccountGroup.AccountTreeController:selectedAccountGroupChange; updates only the selected address.TransactionController:transactionConfirmed, updates only if the tx is for the selected address.KeyringController:unlock-triggered polling andAccountsController:accountAddedupdates.KeyringController:lock.isEvmAccountTypeand guard updates withisEnabled.fetch-positions: usetimeoutWithRetry(8s timeout, 1 retry) for API requests.utils/timeout-with-retrywith tests.CHANGELOG.mdwith breaking changes.Written by Cursor Bugbot for commit d391cf1. This will update automatically on new commits. Configure here.