refactor!: Replace SafeEventEmitterProvider with InternalProvider
#6796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekmarks
changed the title
SafeEventEmitterProvider with InternalProvider
mcmire
reviewed
Oct 7, 2025
There was a problem hiding this comment.
I think there's one thing with the proxies that we may want to adjust, but the rest looks good. Thank you for removing the lint warnings as well!
Can you:
- generate preview builds
- make a new branch on Extension, upgrade
network-controllerto the preview build, push the PR, and wait for CI to pass - build the extension locally, open the test dapp, and make sure you can still make network requests on different chains
- do the same thing for mobile
Let me know if you want to tag team this, I have a bit of time now.
packages/selected-network-controller/src/SelectedNetworkController.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Elliot Winkler <[email protected]>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
cc: @mcmire |
|
@mcmire no problem, I'll keep this as a draft until you tell me otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
As of #6328
SafeEventEmitterProviderno longer used theEventEmitterAPI, making its name misleading. Consequently, this PR renames it toInternalProviderand stops extendingSafeEventEmitter. This new name better reflects its use as an internal-only provider that does not conform to any particular standard.SafeEventEmitterProvideris still exported as a deprecated alias ofInternalProviderin order to resolve a dependency with the repo-external package@metamask/eth-json-rpc-middleware. Once this package has been updated to use the new name, this alias can be removed.References
Closes #6594
Checklist
Note
Replaces
SafeEventEmitterProviderwith newInternalProvider(deprecated alias retained), updates consumers to use it, and swaps provider proxies to swappable proxies, with accompanying tests and changelogs.InternalProvider(no longer extendsSafeEventEmitter); deprecate-exportSafeEventEmitterProvideras alias.@metamask/safe-event-emitterdependency.SafeEventEmitterProvidertoInternalProvider.createSwappableProxy(keep block tracker viacreateEventEmitterProxy).createSwappableProxyfor provider proxies; compatible withInternalProvider.FakeProvider,FakeBlockTracker, bridge/tx tests) to new provider type.Written by Cursor Bugbot for commit b5bcc2c. This will update automatically on new commits. Configure here.