Skip to content

Conversation

afonsobspinto
Copy link
Member

@afonsobspinto afonsobspinto commented Jun 17, 2025

Fixes https://metacell.slack.com/archives/C0477SPSQQK/p1749752077961659?thread_ts=1749743123.149519&cid=C0477SPSQQK

  • Includes all statements in the exported batch (opposed to the original implementation of only keeping the ones that transitioned from npo to exported)
  • Updates get_count_connectivity_statements_* properties to not filter only on NPO_APPROVED
  • Fixes export batch update not being saved

Misc:

  • Fixes frontend build issue

image
image

@afonsobspinto afonsobspinto requested a review from ddelpiano June 17, 2025 22:14
@@ -89,6 +89,6 @@
"eslint": "^8.55.0",
"eslint-plugin-react-hooks": "^4.6.0",
"eslint-plugin-react-refresh": "^0.4.5",
"typescript": "^5.8.3"
"typescript": "^4.9.5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afonsobspinto is this rollback to an older version required or just a typo/leftover from your current setup?

I think @Salam-Dalloul updated this recently since required for the dynamic relationships. Thanks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was done to fix the following pipeline problem:

#16 [frontend 5/7] RUN npm ci
#16 1.691 npm error code ERESOLVE
#16 1.691 npm error ERESOLVE could not resolve
#16 1.691 npm error
#16 1.691 npm error While resolving: [email protected]
#16 1.691 npm error Found: [email protected]
#16 1.691 npm error node_modules/typescript
#16 1.691 npm error   dev typescript@"^5.8.3" from the root project
#16 1.691 npm error   peer typescript@">= 2.7" from [email protected]
#16 1.691 npm error   node_modules/fork-ts-checker-webpack-plugin
#16 1.691 npm error     fork-ts-checker-webpack-plugin@"^6.5.0" from [email protected]
#16 1.691 npm error     node_modules/react-dev-utils
#16 1.691 npm error       react-dev-utils@"^12.0.1" from [email protected]
#16 1.691 npm error       node_modules/react-scripts
#16 1.691 npm error         react-scripts@"5.0.1" from the root project
#16 1.691 npm error   2 more (ts-api-utils, tsutils)
#16 1.691 npm error
#16 1.691 npm error Could not resolve dependency:
#16 1.691 npm error peerOptional typescript@"^3.2.1 || ^4" from [email protected]
#16 1.691 npm error node_modules/react-scripts
#16 1.691 npm error   react-scripts@"5.0.1" from the root project
#16 1.691 npm error
#16 1.691 npm error Conflicting peer dependency: [email protected]
#16 1.691 npm error node_modules/typescript
#16 1.691 npm error   peerOptional typescript@"^3.2.1 || ^4" from [email protected]
#16 1.691 npm error   node_modules/react-scripts
#16 1.691 npm error     react-scripts@"5.0.1" from the root project
#16 1.691 npm error
#16 1.691 npm error Fix the upstream dependency conflict, or retry
#16 1.691 npm error this command with --force or --legacy-peer-deps
#16 1.691 npm error to accept an incorrect (and potentially broken) dependency resolution.
#16 1.691 npm error
#16 1.691 npm error
#16 1.691 npm error For a full report see:
#16 1.691 npm error /root/.npm/_logs/2025-06-17T11_54_16_347Z-eresolve-report.txt
#16 1.695 npm notice
#16 1.695 npm notice New major version of npm available! 10.8.2 -> 11.4.2
#16 1.695 npm notice Changelog: https://github.com/npm/cli/releases/tag/v11.4.2
#16 1.695 npm notice To update run: npm install -g [email protected]
#16 1.695 npm notice
#16 1.695 npm error A complete log of this run can be found in: /root/.npm/_logs/2025-06-17T11_54_16_347Z-debug-0.log
#16 ERROR: process "/bin/sh -c npm ci" did not complete successfully: exit code: 1
------

@ddelpiano ddelpiano merged commit 78a2c67 into develop Jun 23, 2025
1 check passed
@ddelpiano ddelpiano deleted the feature/fix-export-statistics branch July 22, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants