Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cde 39 #34

Merged
merged 5 commits into from
Mar 27, 2024
Merged

Feature/cde 39 #34

merged 5 commits into from
Mar 27, 2024

Conversation

afonsobspinto
Copy link
Member

@afonsobspinto afonsobspinto commented Mar 25, 2024

Closes https://metacell.atlassian.net/browse/CDE-39

  • Adds optional getPairingSuggestions property to collection
  • Implements example of getPairingSuggestions from interlex as explained here.
  • Creates usePairingSuggestions hook to manage pairing suggestions processing
  • Connects mapping tab:
    Upon CDE selection we check for pairing suggestions on each selected collection.
    If we have suggestions we show the collapsible tooltip.
    The user can selected any non-mapped column to map it to the suggestion.
    When a suggestion is accepted we update the dataset mapping accordingly.
  • Connects PairingSuggestions and PairingTooltip components (previously with mocked data)

Questions:

  • Limit pairing suggestions? (we are fetching for at most 20 per collection and showing them all)
  • Tooltip message?
    image

We might need some UI improvements.

2024-03-25.14-16-56.mp4

@ddelpiano
Copy link
Member

@afonsobspinto
Limit the pairing suggestions - no
Tooltip message - In this section the CDE Mapper will present fellow CDEs that are meaningful and usually associated with the parent of the pairing suggestions.

@afonsobspinto afonsobspinto mentioned this pull request Mar 26, 2024
@afonsobspinto
Copy link
Member Author

@afonsobspinto Limit the pairing suggestions - no Tooltip message - In this section the CDE Mapper will present fellow CDEs that are meaningful and usually associated with the parent of the pairing suggestions.

Updated tooltip:
image

I also removed the size:20 from the pairing suggestions query, so there's no limit on how many we can get (which in theory can be problematic, but maybe not in practice)

@zsinnema zsinnema merged commit 62fc8c4 into develop Mar 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants