-
Notifications
You must be signed in to change notification settings - Fork 100
feat(provider): support for additional UTxOs and transactions in transaction evaluation across multi providers #731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…nctions in getAdditionalUtxos
|
While the PR is quite close, it unfortunately has a misunderstanding on the purpose of These two fields are there for transaction chaining, which means they are additional context that doesn't exist on-chain. We should not be fetching this information, because the entire idea is that this information is not available on-chain, and must be provided separately, via this field. The implementation for this should be very simple, no fetching required.
|
|
Thanks for the feedback! I've updated the implementation - switched to offline CBOR parsing instead of fetching. Should be good now 👍 |
|
Thank you! Will have a quick check and merge after. |
|
Ok, I’ll test all of them again because I found a small issue with the Blockfrost provider |
|
If it's at all possible could you add some test cases in the mesh-provider package? It should be possible to run the tests if you set up the .env correctly. |
|
Updated the |
|
Thanks a lot @yanggu0t, I've updated the test case to test for transaction chaining properly. Essentially what I wanted was to evaluate a transaction that uses an input that doesn't exist on-chain. But this input is provided separately. |
ade5796 to
62abb3b
Compare
Summary
Enhances transaction evaluation by adding support for additional UTxOs and transactions across multiple providers.
Implemented Providers
/utils/txs/evaluate/utxosendpoint withadditionalUtxosupportadditionalUtxoSetparameteradditional_utxosparameteradditionalUtxoparameterNot Yet Implemented
Affect components
@meshsdk/common@meshsdk/contract@meshsdk/core@meshsdk/core-csl@meshsdk/core-cst@meshsdk/hydra@meshsdk/provider@meshsdk/react@meshsdk/svelte@meshsdk/transaction@meshsdk/walletType of Change
Related Issues
#499
Checklist
npm run test)npm run build)Additional Information