-
Notifications
You must be signed in to change notification settings - Fork 159
Add x402x facilitator config #382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@jolestar is attempting to deploy a commit to the Merit Systems Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Suggestion:
The x402x facilitator is missing from the "Import Individual Facilitators" code example, even though it's added to the facilitators table as a simple facilitator that requires no setup.
View Details
📝 Patch Details
diff --git a/packages/external/facilitators/README.md b/packages/external/facilitators/README.md
index 110ed7b6..8b1ca5a8 100644
--- a/packages/external/facilitators/README.md
+++ b/packages/external/facilitators/README.md
@@ -136,6 +136,7 @@ import {
heurist,
treasure,
anyspend,
+ x402x,
} from 'facilitators';
// Facilitators requiring setup
Analysis
Missing x402x facilitator in import example
What fails: The README.md documents x402x as an available BASE network facilitator with no setup required in the facilitators table (line 116), but it is not included in the "Import Individual Facilitators" code example (lines 120-139) that shows how to import simple facilitators.
How to reproduce: Open packages/external/facilitators/README.md and compare:
- The facilitators table at line 116 lists x402x as the last entry
- The import example starting at line 120 omits x402x from the imports list
What happens: Users following the documentation example won't know that x402x can be imported alongside other simple facilitators like auto, payai, daydreams, x402rs, corbits, dexter, mogami, openx402, xecho, codenut, ultravioletadao, virtuals, heurist, treasure, and anyspend.
Expected behavior: The x402x import should be added to the simple facilitators import list for consistency with the facilitators table, which already documents it as available with no setup required.
b5d2db2 to
a70ce21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds configuration for a new X402 facilitator called "X402x", an atomic settlement and execution facilitator powered by SettlementRouter with Hook extensibility for programmable payments.
- Adds complete facilitator configuration with 11 BASE network addresses
- Integrates the new facilitator into the package exports and facilitator lists
- Includes branding assets (SVG logo) and documentation updates
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/external/facilitators/src/facilitators/x402x.ts | New facilitator configuration file defining metadata, config URL, and 11 BASE network addresses with USDC support |
| packages/external/facilitators/src/facilitators/index.ts | Exports x402x configuration and facilitator for package consumption |
| packages/external/facilitators/src/lists/all.ts | Adds x402xFacilitator to the validated list of all facilitators |
| packages/external/facilitators/README.md | Documents X402x facilitator in the table and import examples |
| apps/scan/public/x402x.svg | Adds X402x logo SVG with cyan X mark on dark background |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a70ce21 to
bb0c492
Compare
|
fix ci! |
bb0c492 to
98e7a87
Compare
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
a63dbfc to
3dccf13
Compare
|
@shafu0x fixed |
Add Facilitator
Summary
X402xhttps://facilitator.x402x.devhttps://www.x402x.dev@NuwaDevAtomic settlement and execution facilitator powered by SettlementRouter with Hook extensibility for programmable payments.Required changes
packages/facilitators/src/facilitatorspackages/facilitators/src/facilitators/index.tspackages/facilitators/src/lists/all.tsREADME.mdwith a one-line entry under FacilitatorsdateOfFirstTransactionis correct and matches on-chain historyapps/scan/public