fixed the space or rebound issue

[kaustuvpokharel]

Case: In featureList whenever flickable is scrolled fast or scrolled out of bound; it rebounds and parks the feature below the "add feature" button awkwardly.

FIx: Fixed by making the end to be the absolute last feature, without any offsets of the rebound. Now even after rebound it lands/parks on the last feature without the "add feature" button overlapping it.

trim.A3897BF7-6920-42D9-A3D0-C36BEB5AB5C9.MOV

[github-actions]

Pull Request Test Coverage Report for Build 18618380989

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 27 unchanged lines in 4 files lost coverage.
• Overall coverage decreased (-0.02%) to 19.631%

---

Files with Coverage Reduction	New Missed Lines	%
mm/app/attributes/attributecontroller.cpp	1	76.83%
build-mm-db/core/mm_core_autogen/EWIEGA46WW/moc_merginapi.cpp	3	44.31%
mm/core/merginuserauth.cpp	9	68.24%
mm/core/merginapi.cpp	14	74.98%

Totals
Change from base Build 18284755654:	-0.02%
Covered Lines:	13932
Relevant Lines:	70969

---

💛 - Coveralls

[Withalion]

Rule of thumb, if you are fixing/working on UI show us how it looks/works :)

[kaustuvpokharel]

I was building the ios still to take the screenshot, was about to attach. Anyway, thanks for the heads-up @Withalion

[Withalion]

I wouldn't touch cacheBuffer it will break other things, look inside MMListView to find more info.

[kaustuvpokharel]

Well, I believe it wouldn't break anything else, because as you scroll, new delegates need to be created and old ones destroyed technically in the list and this is the main cause for small stutters, and rebound issue.
And the 0 value in MMListView is only stopping the preloading, and it needs to be changed when list stutters because, it's only normal to stutter if the cacheBuffer for list is explicitly set 0.
Preloading 10-15 pixel before hand is no harm. Plus, it only changes for MMFeaturesListPage, not for whole MMListView so I am hoping this is the best approach for this specific case.

[tomasMizera]

Well, I believe it wouldn't break anything else...

Hi @kaustuvpokharel, this is why we set it to 0: #3435 .. chances are that the underlying QT bug is already fixed. If not, this would start to crash on macos/ios. Please try testing it out with >100 features in the list.

[Withalion]

The "spacer" id is not necessary. Let's see what @tomasMizera thinks about it.

[tomasMizera]

Hi @kaustuvpokharel, so which of the two cacheBuffer/snapMode fixed the issue? :)

[kaustuvpokharel]

Hi @kaustuvpokharel, so which of the two cacheBuffer/snapMode fixed the issue? :)

The cacheBuffer fixed it here, and I am explicitly using snapMode which is helping to fall to contentItem on view and not anywhere random i.e. empty spaces or such, so I have kept it for cleaner and safer approach.