Request subset of attributes for LayerFeaturesModel, rework RelationReferenceFeaturesModel #4035
+94
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
QgsAttributeList mAttributeListtoLayerFeaturesModel, which is used to limit the attributes fetched when populating the models usingQgsFeatureRequest::setSubsetOfAttributes.By default all attributes will be fetched, but for example in
MMFeaturesListPagewe can now only request the attributes used for the feature title.This improves performance when the layers have expensive virtual fields or potentially huge number of attributes.
The RelationReferenceFeaturesModel is also reworked so that it only populate a model with required attributes (relation key attributes and the ones used by display expression)