fix(users): secure GET /users and GET /users/:id against PII enumeration [Issue #64] - #76
Merged
Merged
Conversation
|
@gramseostudio-dev is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #64
Description
This PR secures the
GET /usersandGET /users/:idendpoints to prevent PII enumeration, following a rigorous SDD (Specification-Driven Development) workflow.Changes
JwtAuthGuardand@ApiBearerAuth()toGET /usersandGET /users/:idto strictly require valid authentication.PublicUserDtoandtoPublicUsermapper to strip sensitive fields (such asemailandstellarAddress) before reaching the HTTP response.UsersServiceto use the newtoPublicUsermapper for public listings/lookups, while introducingfindOneRawto maintain backward compatibility with internal operations (like role assignments and github upserts).test/users.e2e-spec.ts, backed by a real PostgreSQL instance via Docker (docker compose up db -d), to assert that unauthenticated requests are properly rejected.Verification Steps
docker compose up db -d).npm run test:e2eto verify that unauthenticated requests to user endpoints return unauthorized/forbidden responses as expected.npm run buildto confirm zero type or compilation errors across the NestJS backend graph.emailare completely absent from public-facing responses.