Fix for bug found in Gemini support found during INT tests#24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@google/genaiSDK strictly rejects any message in itscontentsarray that isn't explicitly tagged with theuserormodelrole, throwing a 400INVALID_ARGUMENTerror. When the core Memori engine injected recalled facts using a standard{ role: 'system' }message, the Axon middleware blindly passed it into the Geminicontentsarray.proxy.ts,common.ts, andtypes.ts) to properly intercept and filter outsystemmessages from the main array. Axon now cleanly extracts and maps the system prompt over toconfig.systemInstruction, exactly where modern Gemini models expect it. We also completely overhauled the Gemini type definitions along the way