Added HACS Functionality and cleaned up code.#1
Open
ghost wants to merge 22 commits intoMemberapple:masterfrom
Open
Added HACS Functionality and cleaned up code.#1ghost wants to merge 22 commits intoMemberapple:masterfrom
ghost wants to merge 22 commits intoMemberapple:masterfrom
Conversation
Hacs integration
…t and not necesarry
…, removed legacy AromaLinkCoordinator
- Pass `ssl=AROMA_LINK_SSL` on auth, config flow, and device API requests - Add `AROMA_LINK_SSL = False` constant as workaround for expired cert - Add icon/logo assets under `brand/` and integration `brand/`
Disable Aroma-Link SSL verification and add integration branding assets
- Replace Memberapple GitHub URLs/owner with dalyem in README and manifest - Add README logo and fix manual copy path and service name - Rename HACS display name from "Aroma-Link (New)" to "Aroma-Link"
Disable SSL verification for Aroma-Link API and refresh integration branding/docs
- Move custom component package from `aroma_link_integration` to `ha_aroma_link` - Update Home Assistant domain, manifest metadata, logger path, and service names - Refresh README/HACS naming and document config-entry migration behavior
Rename integration to `ha_aroma_link` and rebrand as HA Aroma-Link
- Move custom component from `ha_aroma_link` to `ha_aromalink` - Update manifest/constants/loggers and bump version to `1.4.0` - Rename display name to `HA Aromalink` in docs, HACS, and translations
Rename integration to `ha_aromalink`, rebrand to HA Aromalink, and apply SSL workaround
- Document re-adding the custom repository after folder/domain renames - Note default-branch requirement for HACS-installed folder/domain changes - Add troubleshooting for `No content to download` with manifest path check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I restructured this to work with HACS. This repo will need a few changes to support that as well. Those being listed below.
I also restructured some of the code, and removed the redundant AromaLinkCoordinator since it was not instantiated anywhere and instead the AromaLinkDeviceCoordinator was being used and contained the same attributes and functions. I also moved the AromaLinkDeviceCoordinator and AromaLinkAuthCoordinator to their own class files to clean up and organize the code.
I also fixed a bug in the AromaLinkDeviceCoordinator, where it would only use the hardcoded 5 second runtime in the run_diffuser function. It would set the work time and pause time appropriately but the delay between the turn on and off was set to a hard coded 5 seconds causing the device to always shut off, 5 seconds into its work time. I now updated it to dynamically use the worktime plus a 5 second buffer before it shuts off again, to ensure the device fully finishes its job.
If you do not plan to maintain this in the future, if you can implement a MIT or APACHE 2.0 license so that I can maintain my own version inside HACS for community use that would be great, alternatively I would also be willing to help maintain this project if you can add me as a contributor I would be happy to help out.