-
Notifications
You must be signed in to change notification settings - Fork 344
Add option for Playtest 1 rules #7404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements Playtest Package #1 Survivability Rules, introducing new side hit location tables and less lethal ammo explosions to improve unit survivability in BattleTech gameplay.
Key changes include:
- New side hit location logic for all Mek types that uses front-facing hit tables and maps results to appropriate side locations
- Ammo explosion damage cap system (20 damage normally, 10 with CASE) that blows out armor when exceeded
- New game option to enable/disable these playtest rules
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| TWDamageManagerModular.java | Adds ammo explosion damage cap logic with CASE considerations |
| TripodMek.java | Implements new side hit location tables for tripod mechs |
| QuadMek.java | Implements new side hit location tables and kick mechanics for quad mechs |
| Mek.java | Implements base new side hit location tables for standard mechs |
| LandAirMek.java | Implements new side hit location tables for land-air mechs |
| OptionsConstants.java | Adds PLAYTEST_1 constant for the new option |
| GameOptions.java | Adds playtest option to game configuration (currently enabled by default) |
| report-messages.properties | Adds message strings for ammo explosion cap reports |
| messages.properties | Adds UI text for the playtest option |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7404 +/- ##
============================================
- Coverage 28.84% 28.84% -0.01%
- Complexity 14147 14154 +7
============================================
Files 3087 3087
Lines 293522 293560 +38
Branches 50939 50955 +16
============================================
+ Hits 84676 84679 +3
- Misses 200922 200937 +15
- Partials 7924 7944 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cef3ff2 to
00358e3
Compare
Co-authored-by: Copilot <[email protected]>
megamek/src/megamek/server/totalWarfare/TWDamageManagerModular.java
Outdated
Show resolved
Hide resolved
Sleet01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace the multiple identical code blocks with a function, and move the option check out of applyPlaytestExplosionReduction() and up into the calling function.
Sleet01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
New side hit location tables and ammo explosion cap.