Add processing of multiple fluff images (WIP) #5490
+486
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaMek + Fix 5476: Update SV armor slots to 2 or 1 for Rating E or F respectively MegaMekLab + Fix #MegaMek#1514: Fix Atrocious table shading render speed MekHQ + PR MegaMek#4106: Use tabs in customize scenario dialog + PR MegaMek#4105: Updated Post-Scenario Logging for Prisoners + PR MegaMek#4104: Fixed Post-Scenario Tracking System's Handling of Multiple Personnel in autoAwards + PR MegaMek#4102: Fixed Award Tier Count Calculations in PersonViewPanel + PR MegaMek#4093: Added Negotiation and Scrounge Skill Settings for Administrator Personnel + PR MegaMek#4054: Added Life Paths Campaign Options Tab, Added Education Module Very Important to read the documentation on this feature (See Docs folder)
# Conflicts: # megamek/docs/history.txt
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5490 +/- ##
============================================
- Coverage 29.68% 29.67% -0.02%
- Complexity 16602 16634 +32
============================================
Files 3139 3140 +1
Lines 302518 302908 +390
Branches 53068 53165 +97
============================================
+ Hits 89804 89884 +80
- Misses 203286 203554 +268
- Partials 9428 9470 +42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Destrier has Sponson Equipment in Inconsistent Location MegaMek#5865
HammerGS
added
the
For New Dev Cycle
Collaborator
|
9 months with no changes. Closing for now. Please re-open when updated. |
Member
|
Please leave open. |
# Conflicts: # megamek/data/mechfiles/vehicles/3145/Davion/Destrier Siege Vehicle.blk # megamek/src/megamek/client/ui/swing/MekViewPanel.java # megamek/src/megamek/client/ui/swing/util/FluffImageHelper.java
|
FWIW, I am super-happy to see this development happening. Can't wait to have it merged. |
# Conflicts: # megamek/docs/AI and MegaMek Suite (Not Princess Stuff).txt # megamek/docs/history.txt # megamek/src/megamek/client/ui/FluffImageTooltip.java # megamek/src/megamek/client/ui/swing/MekViewPanel.java # megamek/src/megamek/client/ui/util/FluffImageHelper.java
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for processing multiple fluff images for units, allowing users to navigate through multiple available images instead of only showing a single image. The implementation is marked as "Work in Progress" and contains test code that needs to be removed before merging.
Changes:
- Added support for retrieving and displaying multiple fluff images per unit
- Implemented image navigation controls (previous/next buttons) in the EntityReadoutPanel
- Created FluffImageTooltip class to display metadata from YAML files associated with fluff images
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 18 comments.
| File | Description |
|---|---|
| TargetRollModifier.java | Added documentation explaining that modifiers apply to target numbers (positive = bad, negative = good) |
| FluffImageHelper.java | Added methods to retrieve multiple fluff images, including directory traversal for chassis/model subdirectories; contains test code that needs removal |
| EntityReadoutPanel.java | Implemented UI controls for navigating multiple fluff images; contains extensive commented-out code that should be removed |
| FluffImageTooltip.java | New utility class for extracting and formatting tooltip information from YAML metadata files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
megamek/src/megamek/client/ui/dialogs/unitSelectorDialogs/EntityReadoutPanel.java
Show resolved
Hide resolved
- Fix getExtension variable bug (filename vs f) - Remove test code: use get(0) instead of random image selection - Fix double setText on imageInfoLabel (removed redundant call) - Add null safety to FluffImageRecord.getImage() for null file - Add null parent check in FluffImageTooltip.getYamlFile() - Add Files.walk depth limits for performance - Fix JavaDoc: return descriptions now match actual behavior - Remove commented-out code blocks - Remove unused prepareLabelText method - Fix path construction for PLACEHOLDER_IMAGE_NAME - Add bounds checks in isSuitableYamlFile()
Member
|
I've used Claude to update the branch, as I'm back to working on the fluff pack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In development