ATAC/DTAC construction rules #1894
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neoancient
requested review from
HammerGS,
NickAragua,
Windchild292 and
sixlettervariables
|
Build scan available at https://gradle.com/s/fcyye6ycvuuhe |
HammerGS
approved these changes
Apr 27, 2020
sixlettervariables
approved these changes
May 1, 2020
Member
Author
|
Made obsolete by #1902. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes the construction rules for the Autonomous Tactical Analysis Computer (ATAC) and Direct Tactical Analysis Computer (DTAC) (see IO, pp. 145-7). Each system has its weight and crew requirements increased by the number of drones it can control. Following the pattern of the remote carrier control system and MASH extra theaters, these are implemented as a separate MiscType that expands the capabilities.
Besides adding ATAC and DTAC to the special handling in the TRO summary I also added the ability to handle plurals correctly. It could be more succinct, but I did it this way to make it easier to handle i18n if we ever get template translations.
I also looked over the similar drone (remote) carrier control system and fixed the tech advancement of the extra drone instance to match the base unit (removing extraneous declaration of default values) and changed the display name to place it near the base unit in an equipment list sorted by name.
See MegaMek/megameklab#570
Fixes MegaMek/megameklab#309