Skip to content
This repository was archived by the owner on Mar 16, 2023. It is now read-only.

Abort controller support implemented #1

Open
developenguin wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Abort controller support implemented #1

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c4edab3
Add support for options object when dispatching
Dec 16, 2019
0c3c683
npm install updates some deps apparently
Dec 16, 2019
e5923bc
Grunt beautify
Dec 16, 2019
9a0270e
Revert "Grunt beautify"
Dec 16, 2019
324ff35
Revert "npm install updates some deps apparently"
Dec 16, 2019
dafffb6
Make options available as eventOptions
Dec 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions backbone.geppetto.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,37 +209,37 @@
return target.listenToOnce(this.vent, eventName, callback, target);
},

dispatch: function dispatch(eventName, eventData) {
dispatch: function dispatch(eventName, eventData, options) {
if (!_.isUndefined(eventData) && !_.isObject(eventData)) {
throw "Event payload must be an object";
}
eventData = eventData || {};
eventData.eventName = eventName;
this.vent.trigger(eventName, eventData);
this.vent.trigger(eventName, eventData, options);
},

dispatchToParent: function dispatchToParent(eventName, eventData) {
dispatchToParent: function dispatchToParent(eventName, eventData, options) {
if (this.parentContext) {
this.parentContext.vent.trigger(eventName, eventData);
this.parentContext.vent.trigger(eventName, eventData, options);
}
},

dispatchToParents: function dispatchToParents(eventName, eventData) {
dispatchToParents: function dispatchToParents(eventName, eventData, options) {
if (this.parentContext && !(eventData && eventData.propagationDisabled)) {
this.parentContext.vent.trigger(eventName, eventData);
this.parentContext.vent.trigger(eventName, eventData, options);
if (this.parentContext) {
this.parentContext.dispatchToParents(eventName, eventData);
this.parentContext.dispatchToParents(eventName, eventData, options);
}
}
},

dispatchGlobally: function dispatchGlobally(eventName, eventData) {
dispatchGlobally: function dispatchGlobally(eventName, eventData, options) {

_.each(contexts, function(context) {
if (!context) {
return true;
}
context.vent.trigger(eventName, eventData);
context.vent.trigger(eventName, eventData, options);
});
},

Expand All @@ -251,13 +251,14 @@
throw "Command must be constructable";
}

this.vent.listenTo(this.vent, eventName, function(eventData) {
this.vent.listenTo(this.vent, eventName, function(eventData, options) {

var commandInstance = new CommandConstructor(context, eventName, eventData);
var commandInstance = new CommandConstructor(context, eventName, eventData, options);

commandInstance.context = context;
commandInstance.eventName = eventName;
commandInstance.eventData = eventData;
commandInstance.eventOptions = options;
context.resolve(commandInstance, wiring);
if (_.isFunction(commandInstance.execute)) {
commandInstance.execute();
Expand Down