-
Notifications
You must be signed in to change notification settings - Fork 0
[Fix] 바텀 내비게이션 UI 수정 #165 #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
다크모드 활성화 시 바텀 내비게이션 바의 애니메이션 동작 중 뒷 배경이 검은색 (Scaffold 기본 색상)으로 칠해지는 문제 해결
Walkthrough메인 액티비티와 바텀 내비게이션 바의 배경색을 테마 색상과 일치하도록 조정했습니다. Scaffold 컨테이너 색상을 백그라운드 색상으로 설정하고, 바텀 바 배경을 흰색으로 통일하여 Figma 디자인과의 정렬을 개선했습니다. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
app/src/main/java/com/konkuk/medicarecall/MainActivity.kt (1)
73-74: 배경색 설정이 중복될 수 있습니다.73번 라인의
.background()모디파이어와 74번 라인의containerColor파라미터가 동일한 색상을 설정하고 있네요. Scaffold의containerColor파라미터가 배경색을 설정하는 표준 방법이므로, 73번 라인의.background()모디파이어는 불필요할 수 있습니다.다음과 같이 수정하면 더 간결해집니다:
Scaffold( - modifier = Modifier.background(MediCareCallTheme.colors.bg), containerColor = MediCareCallTheme.colors.bg, contentWindowInsets = WindowInsets.systemBars.only(WindowInsetsSides.Horizontal),
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
app/src/main/java/com/konkuk/medicarecall/MainActivity.kt(1 hunks)app/src/main/java/com/konkuk/medicarecall/ui/navigation/component/MainBottomBar.kt(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: ci-build
🔇 Additional comments (1)
app/src/main/java/com/konkuk/medicarecall/ui/navigation/component/MainBottomBar.kt (1)
53-58: 바텀 내비게이션 배경 추가가 잘 구현되었습니다!흰색 배경에 회색 테두리를 추가하여 Figma 디자인과 일치시켰네요. 모디파이어 순서도 올바르게 설정되어 있습니다 (background → border).
alswlekk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
librawish808
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋습니다
🔗 관련 이슈
📙 작업 설명
Summary by CodeRabbit