Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

52 accept vtl 21 standard datastructures #53

Merged
merged 31 commits into from
Jan 16, 2025
Merged

52 accept vtl 21 standard datastructures #53

merged 31 commits into from
Jan 16, 2025

Conversation

albertohernandez1995
Copy link
Contributor

No description provided.

@albertohernandez1995
Changed _load_dataset_from_structure function to allow the use of 2.1…
7af90e2 
… VTL standard datastructures.

Nullable attribute in Component class was modified to allow it.
json_schema_2.1.json was created in utils so tests can be performed.
@albertohernandez1995
Amend minor errors
7ec9355
@albertohernandez1995
Added jsonchema validation in _load_dataset_from_structure function t…
038319d 
…o allow the use of VTL 2.1 standard structures

Moved json_schema_2.1.json file to a folder named schema.
@albertohernandez1995
Added test for new standard datastructure. Still need to be reviewed
c64fcf6
@albertohernandez1995
Added test with new data structure standard.
4a766eb
@albertohernandez1995
Added nullable component to vtl 2.1 standard datastructure.
1aa450b 
Although, json_schema_2.1.json was updated to support and to allow the existence of this component when a 2.1 VTL data structure is given.
@albertohernandez1995 albertohernandez1995 linked an issue Jan 7, 2025 that may be closed by this pull request
Accept VTL 2.1 standard datastructures #52
Closed
javihern98
javihern98 requested changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@javihern98 javihern98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to amend the JSON Schema and the default nullability, rest seems good. Some more testing is also needed.

src/vtlengine/API/_InternalApi.py Outdated Show resolved Hide resolved
src/vtlengine/API/data/schema/json_schema_2.1.json Show resolved Hide resolved
tests/API/data/DataStructure/input/DS_Schema.json Outdated Show resolved Hide resolved
javihern98
javihern98 approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@javihern98 javihern98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now, thanks😁

@javihern98
Copy link
Contributor

I will solve conflicts and merge this ASAP

@javihern98
Merge remote-tracking branch 'refs/remotes/origin/main' into 52-accep…
b11b600 
…t-vtl-21-standard-datastructures

# Conflicts:
#	pyproject.toml
#	src/vtlengine/Operators/Conditional.py
#	src/vtlengine/Operators/Time.py
@javihern98
Fixed Conditional on merge.
65c46f4
javihern98
javihern98 approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@javihern98 javihern98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked changes

@javihern98 javihern98 merged commit a611217 into main Jan 16, 2025
11 checks passed
@javihern98 javihern98 deleted the 52-accept-vtl-21-standard-datastructures branch January 16, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javihern98 javihern98 javihern98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accept VTL 2.1 standard datastructures
2 participants
@albertohernandez1995 @javihern98