45 check time period comparison #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he date itself). Refactored all time period tests to work with pytest. Added some basic Time_Period comparison tests: =, <>, <, >, <=, >=.
|
Awaiting for clarification on the criteria to compare Time Periods |
…comparison # Conflicts: # src/vtlengine/DataTypes/__init__.py
javihern98
reviewed
Nov 29, 2024
… new comparison criteria.
javihern98
reviewed
Jan 16, 2025
There was a problem hiding this comment.
@mla2001 Please merge main here solving conflicts. This is the last PR pending. Double check after the merge the Files Changed in the PR to ensure we are only modifying the related files. Ensure we are using ruff 0.8.3 and mypy 1.14.1
Signed-off-by: Mateo de Lorenzo Argelés <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.