Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend mention regex with period + no char limit of 30 #1499

Closed
wants to merge 4 commits into from

Conversation

melroy89
Copy link
Member

@melroy89 melroy89 commented Mar 14, 2025

Seems to work correctly now, tested it with: https://regex101.com/

  • Removing the 30 char limit, just use + meaning one or many matches
  • Add the . (period) symbol as allowed chars

There are several fediverse platforms (software) that support and allow dots in the username. This will take care of this, and render the inline correctly.

@melroy89 melroy89 added the enhancement New feature or request label Mar 14, 2025
@melroy89 melroy89 added this to the v1.8.1 milestone Mar 14, 2025
@melroy89 melroy89 requested a review from BentiGorlich March 14, 2025 16:41
@melroy89 melroy89 changed the title Extend mention regex with period Extend mention regex with period + no char limit of 30 Mar 14, 2025
@melroy89 melroy89 enabled auto-merge (squash) March 28, 2025 17:06
@melroy89 melroy89 requested a review from jwr1 March 30, 2025 14:22
@melroy89 melroy89 disabled auto-merge March 30, 2025 15:58
@melroy89
Copy link
Member Author

This code is wrong.

@melroy89 melroy89 closed this Mar 30, 2025
@melroy89
Copy link
Member Author

New PR: #1533

@jwr1 jwr1 deleted the allow_period_in_username branch March 30, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant