Repository navigation
Conversation
The plugin tile's inspector gets the background row every tile has (the pastel swatches, previewed under the pointer and kept on a click). The layout already keeps a plugin tile's background (core.PLUGIN_TILE_OPTIONS) and the firmware paints it (plugin_host.cpp); only the editor lacked it.
manuugonz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
The inspector of a plugin's tile gets the background row every other tile has (the pastel swatches, previewed under
the pointer and kept on a click, as in TileInspector). The layout already keeps a plugin tile's
background(core.PLUGIN_TILE_OPTIONS) and the firmware already paints it (plugin_host.cpp), so only the editor lacked a way to
choose it; until now it took editing an exported layout. It reuses the existing texts (
editor.tile.sections.style,editor.tile.background.*), so no new strings to translate.screen_manager/app/static is rebuilt from it, as AGENTS.md asks (the second commit, built by GitHub Actions in my
fork).
Related request
No wish yet: this is a small change that is easier to judge as code. Happy to open one on the wishlist if you
prefer.
Validation
In my fork, on GitHub Actions with Node 22:
cd web && npm ci && npm test && npm run build(eslint, vue-tsc, vitest and theVite build) passed, and the build is the second commit here. Python and firmware are untouched.
On a screen: the same change on 0.4.90, run as an app from a fork, with Custom card tiles on an Echo Show 8 (1st gen)
on TECHO5: the swatches show in the plugin tile's inspector, the preview follows the pointer, and the saved
background reaches the screen.
I used Claude (Anthropic's AI assistant) to help write this; I've reviewed it and run it with my own screen.
dev.