Add husky and lint-staged hooks for prettier #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattIPv4
requested changes
Nov 13, 2023
Comment on lines
22
to
27
| "scripts": { | ||
| "test": "tsc --noEmit", | ||
| "build": "tsup", | ||
| "prepublishOnly": "npm run build" | ||
| "prepublishOnly": "npm run build", | ||
| "prepare": "husky install" | ||
| }, |
There was a problem hiding this comment.
We probably want to add lint and format here to run prettier (check and write respectively) -- open to other naming suggestions
Comment on lines
+45
to
+46
| "husky": "^8.0.3", | ||
| "lint-staged": "^15.1.0", |
There was a problem hiding this comment.
Looks like prettier is missing as a development dependency?
MattIPv4
changed the title
|
Ah, and once prettier is in the |
Co-authored-by: Matt Cowley <[email protected]>
Co-authored-by: Matt Cowley <[email protected]>
Open
|
👋 @Dhoni77 checking in to see how this is going? |
|
As there has been no progress for a couple of weeks now, I'm going to close this out and unassign the issue, so someone else can work on this. Feel free to ask to be reassigned if you find the time to continue on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1