leaf.unevaluate -> unevaluated_leaves[leaf] in expression.evaluate_next #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add colophon listing versions used to build doc
Map `Cuboid` with 2d coordinates to `Rectangle`
…ze-calculation Multiply pointSize by 0.5 to follow the new 3d graphics API
Update point size calculation
Segregate image internals
Add transformation functions...
Add section summaries for date & time chapter
Add summary text for Procedural Programming fns
Expand _MPMathMultiFunction to handle a function which is sympy only but not mpmath.
Make a pass over besself fns
Add more spherical Bessel Functions
DOC_USER_TEX_DATA_PATH DOC_SYSTEM_TEX_DATA_PATH
Alllow ENV settings for DOC paths
Add ability to print only chapters or parts of a manual Use smaller font in title for Mathics release number
Useful LaTeX doc tweaks
Builds on what we did before in order to filter by chapter and part. This now gives a us a good ability to QUICKLY iterate over problems in making the doc or in asymptote problem.s
taken from symja
Add GudermannianRules
Add ability to filter doc making by section
Maybe the default was different in an older version of Mathematica? Fixes #1540
Was using wrong default for a,b,c,d...
Would love to ditch this testing mechanism and switch to pytest and sphinx autodoc
Go over docs for Buitin-Function tracing...
The "\|" was shown in the Django documentation, so these tests were removed.
Improve the looking of PrintTrace's docs
The "\|" was shown in the Django documentation, so these tests were removed.
Improve the looking of PrintTrace's docs
and top-level assignments
Also add summary text for these
Start to split out assignments into its own module
remove trailing exit() from debugging.
* add subexpression support * walk_parts_new * adding comments * fix * ensuring that Module uses a copy of the variables * removing set_position method and old ExpressionPointer class, which now are useless * removing old walk_parts * fix Graphics and Graphics3D * fix graphics and strings * Using references to symbols instead of create them * update the name of the parameter * removing more on the fly building of system symbols * adding docstrings * adding CHANGES * improvements from comments * removing assert in get_class. Improving description in CHANGES.rst * removing heads argument in mathics.algorithm.parts._list_parts * rocky's rewording of the mathics.algorithm.parts._list_parts docstring * mathics.algorithm.parts - Improving docstrings. Renaming parameters for clarity. Removing unused parameters. * pspect -> part specification * Small doc tweaks Note: use `` `` in RsT/Sphinx for code inline markup. * tuple-> frozenset in system_symbols * Add dosctring for system_symbols; why frozeset Co-authored-by: rocky <[email protected]>
Replace from_python by a more specific function in some places
TiagoCavalcante
approved these changes
Nov 9, 2021
TiagoCavalcante
force-pushed
the
master
branch
from
edcaf4c to
6340c1b
Compare
Open
|
As I explain in #122, this solution does not work :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
Expression.evaluate_next, part of the algorithm requires to keep a register of what leaves were evaluated in certain stages. It was done by setting an "ad-hoc" property.unevaluatein the Expression object. That was OK whenSymbolwas not a singleton. Now, two different leaves with the same symbol will have the same property, so this strategy becomes fragile. This PR is a first step for removing this fragility.