Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update intracellular in first time step #364

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

drbergman
Copy link
Collaborator

@drbergman drbergman commented Feb 18, 2025

Low priority PR that fixes bug causing intracellular updates to skip the first diffusion time step at t=0. I don't believe that PhysiBoSS or PhysiCelldFBA require this step to be skipped, but please inform if it is necessary :)

It is possible that rules that depend on variables expected to be set in a post_intracellular_update function could receive unexpected inputs causing unintended behavior in the first advance_bundled_phenotype_functions and subsequent mechanics updates.

  • this change allows intracellular updates to occur in the first diffusion step
  • before, they had to wait one diffusion step to update (if there's a reason for this, it's lost on me)
  • removed need for initialzed [sic] field in Cell_Container class
  • also make easier-to-parse logic and variable names for when to update phenotype and mechanics

- this change allows intracellular updates to occur in the first diffusion step
- before, they had to wait one diffusion step to update (I don't see a reason why)
- removed need for `initialzed` [sic] field in `Cell_Container` class
- also make easier-to-parse logic and variable names for when to update phenotype and mechanics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant