Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: do not generate timestamp bindings for CDCv2 sources #11671

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

petrosagg
Copy link
Contributor

Motivation

Fix MaterializeInc/database-issues#3355. CDCv2 sources don't need bindings since their timestamps are completely governed by the actual data stream.

Testing

  • This PR has adequate test coverage / QA involvement has been duly considered.

Release notes

This PR includes the following user-facing behavior changes:

@petrosagg petrosagg requested a review from frankmcsherry April 8, 2022 16:11
Copy link
Contributor

@frankmcsherry frankmcsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit! I don't understand if this wedges CDCv2 or leaves it in a healthy state, but the implementation does seem to better conform to the documentation!

@CLAassistant
Copy link

CLAassistant commented Dec 8, 2022

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants