Fix Node module import issue#3
Open
ac-freeman wants to merge 1 commit into
Open
Conversation
ErikGrigoriev
approved these changes
Jun 25, 2019
Owner
|
Hi Andrew, I agree that the fix you suggested is the cleanest, as there is only one export from index.js, so there is no need for a separate MailListener property of module.exports. (See my comments to Issues #2 and #7 ) Having said that, it is a breaking change that would affect others who have managed to import the module by using one of the methods mentioned in those issues (e.g. using ES6 destructuring). As such, I will likely merge this after I've had a look at the various forks and NPM packages floating around with this functionality & given people some notice that this change is coming. I will shortly fix the README though so that it reflects the correct way to import the package in the meantime. Thanks M |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue #2