Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subpass dependencies to examples #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

YouSafe
Copy link
Contributor

@YouSafe YouSafe commented Apr 6, 2024

This PR aims to fix some of the sync validation errors.

Adding those subpass dependencies fixes all sync issues for the example example but NOT for user_texture.

Fixing user_texture takes a bit more work, as the current swapchain image is used for both shader read and color attachment at the same time. A potential fix would be to render the scene onto a separate image.

Also, the // Clear framebuffer section is not needed because begin_render_pass already clears the framebuffer image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant