This repository has been archived by the owner on Nov 5, 2019. It is now read-only.
Try to debug unrequired .changed() calls #348
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magnusulf
force-pushed
the
lastraw
branch
2 times, most recently
from
7c9bb4a to
6db82dd
Compare
oloflarsson
reviewed
Apr 29, 2018
| @@ -607,6 +613,7 @@ private void checkActuallyModifiedFixed(String id) | |||
| String change = Txt.implode(messages, Txt.parse("<silver> | ")); | |||
| String message = Txt.parse("<b>[No Modification] %s", change); | |||
| this.getPlugin().log(message); | |||
| this.getPlugin().log(MUtil.getStackTraceString(entity.getStackTraceChanged(), true);); | |||
There was a problem hiding this comment.
🤖 - Looks like we have one more semicolon than required on this row?
| @@ -607,6 +612,7 @@ private void checkActuallyModifiedFixed(String id) | |||
| String change = Txt.implode(messages, Txt.parse("<silver> | ")); | |||
| String message = Txt.parse("<b>[No Modification] %s", change); | |||
| this.getPlugin().log(message); | |||
| this.getPlugin().log(MUtil.getStackTraceString(entity.getLastStackTraceChanged(), true)); | |||
There was a problem hiding this comment.
Add NPE check? What if the stack trace is null?
oloflarsson
reviewed
Apr 29, 2018
| public void changed() | ||
| { | ||
| super.changed(); | ||
| if (!ConfServer.localPollingEnabled || !MassiveCoreMConf.get().warnOnLocalAlter) return; |
There was a problem hiding this comment.
Duplicate source code? If we check for this configuration multiple times, perhaps break out a common method for it?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.