Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken links through PR on Style Guide repo #45

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

guidodemmenie
Copy link
Collaborator

Fixing broken links to new documentation Robocop

As per PR from @kkotenko
MarketSquare/robotframework-style-guide#59

@guidodemmenie guidodemmenie requested review from kstine and Mko13 March 8, 2024 13:14
@Mko13
Copy link
Collaborator

Mko13 commented Mar 8, 2024

In such cases, we can retain original contributor by amending the latest commit with git commit --amend --author="Name Surname <[email protected]>" --no-edit.

Or we can include some additional info in the commit, e.g., in style-guide repo, I recently had such case - I used interactive rebase (`git rebase -i) and added info about co-author in the commit message:
image.

Github preview:
image

@guidodemmenie guidodemmenie self-assigned this Mar 8, 2024
@guidodemmenie guidodemmenie marked this pull request as draft March 8, 2024 15:44
@guidodemmenie
Copy link
Collaborator Author

Good point I'll make sure we preserve the original author, maybe easiest way is to create a new PR for that .. but I'll look into that.

@guidodemmenie guidodemmenie force-pushed the style-guid-fix-broken-links-robocop branch from 4823867 to 2f95dad Compare March 19, 2024 14:26
@guidodemmenie guidodemmenie marked this pull request as ready for review March 19, 2024 14:32
@guidodemmenie guidodemmenie merged commit 34cbc5d into main Mar 19, 2024
1 check passed
@guidodemmenie guidodemmenie deleted the style-guid-fix-broken-links-robocop branch March 19, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants