Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor file viewer #7270

Draft
wants to merge 37 commits into
base: master
Choose a base branch
from
Draft

Refactor file viewer #7270

wants to merge 37 commits into from

Commits on Oct 19, 2024

  1. Return extra file information for submission files

    @ch-iv
    ch-iv committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    33d06b4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'MarkUsProject:master' into refactor-file-viewer

    @ch-iv
    ch-iv authored Oct 19, 2024
    Configuration menu
    Copy the full SHA
    1d1b88f View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2024

  1. Parse extra submission file attributes

    @ch-iv
    ch-iv committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    1eaf4e7 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Revert providing size info with result show request

    @ch-iv
    ch-iv committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    b039249 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'MarkUsProject:master' into refactor-file-viewer

    @ch-iv
    ch-iv authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    44798f1 View commit details
    Browse the repository at this point in the history

  3. Revert providing size info with result show request

    @ch-iv
    ch-iv committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    67d406b View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Pass file type to the selector

    @ch-iv
    ch-iv committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    451d5aa View commit details
    Browse the repository at this point in the history

  2. Fix restructuring of non-iterable object

    @ch-iv
    ch-iv committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    4e69ebc View commit details
    Browse the repository at this point in the history

  3. Add type to FileViewer props

    @ch-iv
    ch-iv committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    0149a3c View commit details
    Browse the repository at this point in the history

  4. Remove redundant get_file request

    @ch-iv
    ch-iv committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    79689b6 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Fetch files using a single request

    @ch-iv
    ch-iv committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    27a36b1 View commit details
    Browse the repository at this point in the history

  2. Reject promise on invalid request

    @ch-iv
    ch-iv committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    b047953 View commit details
    Browse the repository at this point in the history

  3. Revert passing additional props to FileSelector

    @ch-iv
    ch-iv committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    56a8e32 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Unify common props

    @ch-iv
    ch-iv committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    9a1209e View commit details
    Browse the repository at this point in the history

  2. Move HEIC/HEIF file handling to the image viewer

    @ch-iv
    ch-iv committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    ed6d568 View commit details
    Browse the repository at this point in the history

  3. Refactor setFileURL

    @ch-iv
    ch-iv committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    2eecc48 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Refactor text viewer to fetch content from URL

    @ch-iv
    ch-iv committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    e09d25a View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Refactor FileViewer

    @ch-iv
    ch-iv committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    051d44d View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Add callbacks to BinaryViewer

    @ch-iv
    ch-iv committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    344d2ab View commit details
    Browse the repository at this point in the history

  2. Pass the correct URL to child viewer components

    @ch-iv
    ch-iv committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    f9a18ea View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Introduce callbacks

    @ch-iv
    ch-iv committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    e689741 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Cancel promises and state updates after component unmount

    @ch-iv
    ch-iv committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    48b9337 View commit details
    Browse the repository at this point in the history

  2. Add missing heic2any import

    @ch-iv
    ch-iv committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    2141d22 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. Remove mounted guards for promises

    @ch-iv
    ch-iv committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    a15b80c View commit details
    Browse the repository at this point in the history

  2. Fix HEIC/HEIF images failing to load

    @ch-iv
    ch-iv committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    65cca63 View commit details
    Browse the repository at this point in the history

  3. Simplify AbortController logic

    @ch-iv
    ch-iv committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    8366aeb View commit details
    Browse the repository at this point in the history

  4. Catch DOMException

    @ch-iv
    ch-iv committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    3ffa9c6 View commit details
    Browse the repository at this point in the history

  5. Remove debug console message

    @ch-iv
    ch-iv committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    2acd835 View commit details
    Browse the repository at this point in the history

  6. Add max_content_size param to /download_file

    @ch-iv
    ch-iv committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    35275d3 View commit details
    Browse the repository at this point in the history

  7. Handle (413 Content Too Large) when fetching file content

    @ch-iv
    ch-iv committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    8aa5fa9 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into refactor-file-viewer 

    # Conflicts:
#	app/assets/javascripts/Components/Result/file_viewer.jsx
    @ch-iv
    ch-iv committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    dd8e8ee View commit details
    Browse the repository at this point in the history

  9. Switch to existing oversized file message

    @ch-iv
    ch-iv committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    1655953 View commit details
    Browse the repository at this point in the history

  10. Restore previous max content sizes

    @ch-iv
    ch-iv committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    6d4c243 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. Create mock fetch test for TextViewer

    @ch-iv
    ch-iv committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    89b6aaf View commit details
    Browse the repository at this point in the history

  2. Add binary file extensions

    @ch-iv
    ch-iv committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    a1bd279 View commit details
    Browse the repository at this point in the history

  3. Change getAnyway functionality to be local to the BinaryViewer

    @ch-iv
    ch-iv committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    fbbff76 View commit details
    Browse the repository at this point in the history

  4. Test BinaryViewer URL fetching

    @ch-iv
    ch-iv committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    1a83fe1 View commit details
    Browse the repository at this point in the history